PIDController: getError() is incorrect when setContinuous is True #31

Closed
virtuald opened this Issue May 15, 2016 · 0 comments

Projects

None yet

1 participant

@virtuald
Member

It returns a raw calculation, does not compensate for wraparound (see code inside calculate() for correct implementation).

@calcmogul calcmogul added a commit to calcmogul/allwpilib that referenced this issue Jul 12, 2016
@calcmogul calcmogul Fixed PIDController::GetError() for continuous inputs
Closes #31
0067f62
@calcmogul calcmogul added a commit to calcmogul/allwpilib that referenced this issue Jul 12, 2016
@calcmogul calcmogul Fixed PIDController::GetError() for continuous inputs
Closes #31
7a52206
@calcmogul calcmogul added a commit to calcmogul/allwpilib that referenced this issue Jul 13, 2016
@calcmogul calcmogul Fixed PIDController::GetError() for continuous inputs
Closes #31
06b1143
@calcmogul calcmogul added a commit to calcmogul/allwpilib that referenced this issue Jul 13, 2016
@calcmogul calcmogul Fixed PIDController::GetError() for continuous inputs
Closes #31
dc1234e
@calcmogul calcmogul added a commit to calcmogul/allwpilib that referenced this issue Jul 15, 2016
@calcmogul calcmogul Fixed PIDController::GetError() for continuous inputs
Closes #31
7f3f923
@PeterJohnson PeterJohnson closed this in #169 Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment