Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpilib] Document simulation APIs #3079

Merged
merged 1 commit into from Jan 12, 2021

Conversation

PeterJohnson
Copy link
Member

@PeterJohnson PeterJohnson commented Jan 11, 2021

  • Remove sim checkstyle suppression
  • Add [[nodiscard]] to C++ register callback functions
  • Add a couple of missing sim functions

This is a cleaned up version of #2714.

- Remove sim checkstyle suppression
- Add [[noexcept]] to C++ register callback functions
- Add a couple of missing sim functions

Co-authored-by: Peter Johnson <johnson.peter@gmail.com>
@Starlight220
Copy link
Member

A few things:

  • link this to 1290
  • do you want to document Joystick.getAxisType() ret vals (and the other usages of axis types) here or in a separate PR?

@prateekma
Copy link
Member

[[noexcept]] -> [[nodiscard]] in commit message

@PeterJohnson
Copy link
Member Author

Let's keep this sim-oriented.

@PeterJohnson PeterJohnson merged commit 9c3b51c into wpilibsuite:master Jan 12, 2021
@PeterJohnson PeterJohnson deleted the cleanup-2714 branch January 12, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants