From 46a51943f766f7886bcdcfb2d4d99bb0474a377b Mon Sep 17 00:00:00 2001 From: Starlight220 <53231611+Starlight220@users.noreply.github.com> Date: Wed, 22 Nov 2023 19:03:52 +0200 Subject: [PATCH 1/3] [java] Default LiveWindowEnabledInTest=false --- .../main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java index 4afece468d9..644e7cc4dd7 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java @@ -70,7 +70,7 @@ private enum Mode { private final double m_period; private final Watchdog m_watchdog; private boolean m_ntFlushEnabled = true; - private boolean m_lwEnabledInTest = true; + private boolean m_lwEnabledInTest = false; private boolean m_calledDsConnected; /** @@ -260,7 +260,7 @@ public void setNetworkTablesFlushEnabled(boolean enabled) { /** * Sets whether LiveWindow operation is enabled during test mode. Calling * - * @param testLW True to enable, false to disable. Defaults to true. + * @param testLW True to enable, false to disable. Defaults to false. * @throws ConcurrentModificationException if this is called during test mode. */ public void enableLiveWindowInTest(boolean testLW) { From 937d7e4b8a3e8707996dd579d239b051d3c30d57 Mon Sep 17 00:00:00 2001 From: Starlight220 <53231611+Starlight220@users.noreply.github.com> Date: Wed, 22 Nov 2023 19:06:52 +0200 Subject: [PATCH 2/3] [cpp] Default LiveWindowEnabledInTest=false --- wpilibc/src/main/native/include/frc/IterativeRobotBase.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wpilibc/src/main/native/include/frc/IterativeRobotBase.h b/wpilibc/src/main/native/include/frc/IterativeRobotBase.h index 42b0c715df7..79c1de2cbc2 100644 --- a/wpilibc/src/main/native/include/frc/IterativeRobotBase.h +++ b/wpilibc/src/main/native/include/frc/IterativeRobotBase.h @@ -215,7 +215,7 @@ class IterativeRobotBase : public RobotBase { /** * Sets whether LiveWindow operation is enabled during test mode. * - * @param testLW True to enable, false to disable. Defaults to true. + * @param testLW True to enable, false to disable. Defaults to false. * @throws if called in test mode. */ void EnableLiveWindowInTest(bool testLW); @@ -252,7 +252,7 @@ class IterativeRobotBase : public RobotBase { units::second_t m_period; Watchdog m_watchdog; bool m_ntFlushEnabled = true; - bool m_lwEnabledInTest = true; + bool m_lwEnabledInTest = false; bool m_calledDsConnected = false; void PrintLoopOverrunMessage(); From c279c113140003a27946f368c26f569b988a2b26 Mon Sep 17 00:00:00 2001 From: Starlight220 <53231611+Starlight220@users.noreply.github.com> Date: Wed, 22 Nov 2023 20:22:28 +0200 Subject: [PATCH 3/3] remove redundant initializer --- .../src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java index 644e7cc4dd7..bbc98a41086 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java @@ -70,7 +70,7 @@ private enum Mode { private final double m_period; private final Watchdog m_watchdog; private boolean m_ntFlushEnabled = true; - private boolean m_lwEnabledInTest = false; + private boolean m_lwEnabledInTest; private boolean m_calledDsConnected; /**