Reduced minimum update rate from 100 ms to 10 ms. #89

Merged
merged 1 commit into from Aug 16, 2016

Projects

None yet

3 participants

@PeterJohnson
Member

No description provided.

@PeterJohnson PeterJohnson Reduced minimum update rate from 100 ms to 10 ms.
601ae8d
@ThadHouse
Member

LGTM

@PeterJohnson
Member

@Kevin-OConnor ok with this change? Note the default update rate is still 100 ms.

@Kevin-OConnor

LGTM.

I think the default rate is fine for the vast majority of teams. Lowering the min (and at some point documenting, probably in Screensteps somewhere, that you can speed up the update rate) should cover most of the cases where someone rolled their own protocol just due to speed/latency.

@ThadHouse
Member

i'd probably recommend on screen steps keeping update rate at 100ms anyway, and just have teams flush when they have data they wanted updated faster. That'd probably work better for teams that knew enough and actually needed faster data.

@PeterJohnson PeterJohnson merged commit 1635cba into master Aug 16, 2016

4 checks passed

Details continuous-integration/appveyor/branch AppVeyor build succeeded
Details continuous-integration/appveyor/pr AppVeyor build succeeded
Details continuous-integration/travis-ci/pr The Travis CI build passed
Details continuous-integration/travis-ci/push The Travis CI build passed
@PeterJohnson PeterJohnson deleted the reduced-rate-limit branch Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment