Uploader changes #229

Merged
merged 1 commit into from Feb 25, 2013

Conversation

Projects
None yet
2 participants
@funkedgeek
Contributor

funkedgeek commented Feb 25, 2013

No description provided.

@rilwis

This comment has been minimized.

Show comment Hide comment
@rilwis

rilwis Feb 25, 2013

Collaborator

I see you did a lot of changes in name conversion. I think we should keep using this_name format for name, to make everything compatible with WP.

Collaborator

rilwis commented Feb 25, 2013

I see you did a lot of changes in name conversion. I think we should keep using this_name format for name, to make everything compatible with WP.

@funkedgeek

This comment has been minimized.

Show comment Hide comment
@funkedgeek

funkedgeek Feb 25, 2013

Contributor

I made the change because that's the way WordPress does it internally for
JavaScript

On Mon, Feb 25, 2013 at 2:23 AM, Tran Ngoc Tuan Anh <
notifications@github.com> wrote:

I see you did a lot of changes in name conversion. I think we should keep
using this_name format for name, to make everything compatible with WP.


Reply to this email directly or view it on GitHubhttps://github.com/rilwis/meta-box/pull/229#issuecomment-14030209.

Contributor

funkedgeek commented Feb 25, 2013

I made the change because that's the way WordPress does it internally for
JavaScript

On Mon, Feb 25, 2013 at 2:23 AM, Tran Ngoc Tuan Anh <
notifications@github.com> wrote:

I see you did a lot of changes in name conversion. I think we should keep
using this_name format for name, to make everything compatible with WP.


Reply to this email directly or view it on GitHubhttps://github.com/rilwis/meta-box/pull/229#issuecomment-14030209.

@rilwis

This comment has been minimized.

Show comment Hide comment
@rilwis

rilwis Feb 25, 2013

Collaborator

OK, no problem. I'll accept the pull request now.

Collaborator

rilwis commented Feb 25, 2013

OK, no problem. I'll accept the pull request now.

@rilwis rilwis closed this Feb 25, 2013

@rilwis rilwis reopened this Feb 25, 2013

rilwis added a commit that referenced this pull request Feb 25, 2013

@rilwis rilwis merged commit 0bc6499 into wpmetabox:master Feb 25, 2013

@funkedgeek

This comment has been minimized.

Show comment Hide comment
@funkedgeek

funkedgeek Feb 25, 2013

Contributor

This solves rilwis#39

Contributor

funkedgeek commented on dca9a7e Feb 25, 2013

This solves rilwis#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment