Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Avoid empty descriptions in template.py #88

Closed
Daniel-Mietchen opened this Issue Jul 8, 2013 · 15 comments

Comments

Projects
None yet
2 participants

@ghost ghost assigned erlehmann Jul 8, 2013

Assertion introduced as of ceba6b6. Bug will be closed as soon as I know what should be done instead.

Owner

Daniel-Mietchen commented Aug 25, 2013

just leave the description field empty then - there is a Commons category that allows to track such cases.

Hopefully fixed as of 13cd48b.

@erlehmann erlehmann closed this Sep 28, 2013

Owner

Daniel-Mietchen commented Sep 28, 2013

Looks good, thanks.

The XML in question is:

      <supplementary-material content-type="local-data">
        <media xlink:href="Movie3.MOV">
          <caption>
            <p>Click here for additional data file.</p>
          </caption>
        </media>
      </supplementary-material>
Owner

Daniel-Mietchen commented Oct 7, 2013

Sure, but since we ignore statements containing "click", there should be no

{{en|1= }}

on the page, as this requires cleanup as per
https://commons.wikimedia.org/w/index.php?title=File%3ASide-effect-of-acting-on-the-world-acquisition-of-action-outcome-statistic-relation-alters-visual-Movie3.ogv&diff=106524701&oldid=106502877 .

Let me find where the cleanup happens.

The description seems to be a single space.

Owner

Daniel-Mietchen commented Oct 7, 2013

Yep. Where does that come from?

Whitespace issue should be fixed as of b91c061.

I think the single space is an artifact of the cleanup process.

@erlehmann erlehmann closed this Oct 7, 2013

Owner

Daniel-Mietchen commented Oct 7, 2013

Looks good, thanks. Next one is erlehmann#111 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment