Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving CSS stylesheet edits with JetPack's Edit CSS doesn't clear the cache #246

Closed
raamdev opened this issue Jul 24, 2014 · 3 comments
Closed
Labels
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jul 24, 2014

When saving CSS stylesheet edits with JetPack's Edit CSS module, Quick Cache should purge the entire site cache, as the CSS may affect any part of the site. Currently, this does not happen and instead, oddly enough, only Author Page caches appear to get cleared:

2014-07-24_13-23-50


Steps to recreate this issue

  1. Install JetPack and activate the Edit CSS module
  2. Visit a Post/Page on the site to create a cache of that Post/Page
  3. Add some custom CSS that modifies something visible on the cached Post/Page using the Edit CSS module (Dashboard → Appearance → Edit CSS)
  4. Visit the Post/Page and notice that your edit is not visible because Quick Cache is loading an old cache of that page.
@raamdev raamdev added bug labels Jul 24, 2014
@raamdev raamdev added this to the Next Release milestone Sep 19, 2014
@raamdev raamdev closed this in 6318267 Sep 20, 2014
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Sep 20, 2014
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Sep 20, 2014

Whoops. I forgot to follow the HubFlow format for this bug and accidentally committed directly to the 000000-dev branch.

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Sep 20, 2014

Next release changelog:

  • Bug Fix: When saving custom CSS using JetPack's Custom CSS module, Quick Cache now properly purges the site cache to ensure that outdated cache files are not served to visitors. See #246.
@jaswrks
Copy link

@jaswrks jaswrks commented Sep 20, 2014

Cool :-) That's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants