Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash missing from UI in Directory/Expiration Time panel #267

Closed
raamdev opened this issue Aug 6, 2014 · 5 comments
Closed

Slash missing from UI in Directory/Expiration Time panel #267

raamdev opened this issue Aug 6, 2014 · 5 comments
Labels
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Aug 6, 2014

See screenshot:

2014-08-05_22-57-45


Reported here: https://websharks.zendesk.com/agent/#/tickets/3360

@raamdev raamdev added bug labels Aug 6, 2014
@raamdev raamdev added this to the Next Release milestone Sep 19, 2014
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Sep 19, 2014

Noting here that in all three places where WP_CONTENT_DIR is defined by WordPress, a trailing slash is not present and therefore should be added to the Quick Cache UI for clarity:

wp-admin/setup-config.php:

define('WP_CONTENT_DIR', ABSPATH . 'wp-content');

wp-includes/default-constants.php:

define( 'WP_CONTENT_DIR', ABSPATH . 'wp-content' ); // no trailing slash, full paths only - WP_CONTENT_URL is defined further down

wp-load.php:

define( 'WP_CONTENT_DIR', ABSPATH . 'wp-content' );
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Sep 19, 2014

2014-09-19_19-57-08

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Sep 19, 2014

Closed by PR #325 and wpsharks/comet-cache-pro#80.

@raamdev raamdev closed this Sep 19, 2014
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Sep 20, 2014

Next release changelog:

  • Bug Fix: Fixed missing trailing slash in Directory / Expiration Time configuration panel. This was purely a visual inconsistency and had no effect on Quick Cache's functionality.
@jaswrks
Copy link

@jaswrks jaswrks commented Sep 20, 2014

Awesome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants