Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanging Code (-->) #295

Closed
jbtokc opened this issue Aug 30, 2014 · 8 comments
Closed

Hanging Code (-->) #295

jbtokc opened this issue Aug 30, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@jbtokc
Copy link

@jbtokc jbtokc commented Aug 30, 2014

I've noticed that there is some code missing somewhere that is causing "-->" to sit at the top of my screen.

Here is a look at the upper left corner (header) before I deactivate the QuickCache plugin:

screenshot 2014-08-30 at 5 25 26 am

And this is what my site looks like after I deactivate the plugin:

screenshot 2014-08-30 at 5 24 15 am

The issue adds space to the header.

@jaswrks
Copy link

@jaswrks jaswrks commented Aug 30, 2014

Thanks for reporting this! Are you running the pro version? If so, do you have the HTML Compressor running also? If that's also true, please paste a screenshot of your HTML Compressor configuration from the Quick Cache options panel, along with a link which leads to the page where this is occurring (if that's possible).

Just need a bit more information please. Thanks!

@jbtokc
Copy link
Author

@jbtokc jbtokc commented Aug 30, 2014

Yes, I'm running HTML Compressor.

screenshot 2014-08-30 at 5 39 27 am

The site is: thedroidlawyer.com

@jbtokc
Copy link
Author

@jbtokc jbtokc commented Aug 30, 2014

I guess I should add the bottom stuff, too.

screenshot 2014-08-30 at 5 46 33 am

@jaswrks
Copy link

@jaswrks jaswrks commented Sep 1, 2014

Thanks! I'm taking a closer look at this issue, and #299 also.

@jaswrks
Copy link

@jaswrks jaswrks commented Sep 1, 2014

Tracking progress on this here: wpsharks/html-compressor#39

@jaswrks
Copy link

@jaswrks jaswrks commented Sep 2, 2014

Resolved in the release of HTML Compressor v140901; targeted at the master branch. cc @raamdev https://github.com/websharks/html-compressor/releases

~ Referencing: http://stackoverflow.com/a/12102131


This fix will likely be included in the next release of QCP.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 2, 2014

@jaswsinc Thanks so much for fixing this!

@jbtokc Thanks so much for the bug report! This will be fixed in the next release.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 2, 2014

Next release changelog:

  • Bug Fix (Pro): Fixed a bug in the HTML Compressor that would, in certain scenarios, leave behind fragments of HTML comments. See #295.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants