Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage cache not refreshed after posting new post #365

Closed
baspisa opened this issue Nov 16, 2014 · 16 comments
Closed

Homepage cache not refreshed after posting new post #365

baspisa opened this issue Nov 16, 2014 · 16 comments
Labels
Milestone

Comments

@baspisa
Copy link

@baspisa baspisa commented Nov 16, 2014

When I publish a new post it does not show on the homepage when logged out. (Old cache is shown). Page served is not in the browser cache. For me (Lite user) the only option to refresh my homepage is to disable and re-enable the plugin. This behaviour was introduced with version v141110

@Kalfer
Copy link

@Kalfer Kalfer commented Nov 17, 2014

I confirm too. If "Auto-Clear Home Page" is enabled, the cache is not cleared when you publish a new post.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 18, 2014

Thank you for the bug report. I have confirmed this bug as well. I will investigate further and update here when I know more.

@raamdev raamdev added the bug label Nov 18, 2014
@raamdev raamdev added this to the Next Release milestone Nov 18, 2014
@raamdev raamdev self-assigned this Nov 18, 2014
@raamdev raamdev added pro lite labels Nov 18, 2014
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 18, 2014

The underlying cause of this is an extra leading \/ in one of our regex patterns.

No match...

$string = '/index.u/1.html';
$regex = '/\/(?:\/index)?(?:\.|\/(?:page\/[0-9]+|comment\-page\-[0-9]+)[.\/])/i';

preg_match($regex, $string, $m);
print_r($m);

Matches properly...

$string = '/index.u/1.html';
$regex = '/(?:\/index)?(?:\.|\/(?:page\/[0-9]+|comment\-page\-[0-9]+)[.\/])/i';

preg_match($regex, $string, $m);
print_r($m);
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 18, 2014

Referencing this line of code...
https://github.com/websharks/quick-cache-pro/blob/000000-dev/quick-cache-pro/includes/share.php#L1560

We need to consider that $_host_cache_dir_tmp_regex may contain \/(?:\/index)?. In other words, a simple ltrim() will not work here, we need to be more particular about how this is sanitized to avoid the issue reported here.

@jaswrks
Copy link

@jaswrks jaswrks commented Nov 19, 2014

PRs submitted that resolve this issue.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 19, 2014

@jaswsinc Thanks so much for fixing this! PRs have been merged.

@baspisa @Kalfer This has been fixed in the development trunk and the fix will go out with the next release. If you're interested in testing a beta release of Quick Cache before the next version comes out, please sign-up to be a beta tester here.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 19, 2014

Next release changelog:

  • Bug Fix: Fixed a Home Page clearing bug that arose in the previous release as the result of an extra leading \/ in one of our regex patterns. Props @jaswsinc. See #365.
@raamdev raamdev closed this Nov 19, 2014
@Kalfer
Copy link

@Kalfer Kalfer commented Nov 19, 2014

@raamdev I am a beta tester. What I have to do to test the beta?

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 19, 2014

@Kalfer

I am a beta tester. What I have to do to test the beta?

You'll receive an email with instructions when the Release Candidate is published.

@iGameMom
Copy link

@iGameMom iGameMom commented Nov 26, 2014

I am having the same problem. When will be the next release? What is your suggestion for a temporary fix before the new release?

@iGameMom
Copy link

@iGameMom iGameMom commented Nov 26, 2014

@raamdev do you have an estimate when the new release will be out and fix the issue?

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 27, 2014

@iGameMom We're doing a beta release today and will likely have the next public release over the weekend or on Monday at the latest. If you're interested in testing a beta release of Quick Cache before the next version comes out, please sign-up to be a beta tester here.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 5, 2014

The latest release of Quick Cache, v141205, includes a fix for this issue: http://www.websharks-inc.com/post/quick-cache-v141205-now-available/

@yankustefan
Copy link

@yankustefan yankustefan commented Mar 24, 2016

Hi, is Quick Cache v141205 still accessible. Or log of the changes made?
I still have 131206 on an WP 3.7.1 and don't have the time to upgrade WP and migrate to Comet Cache.
Thanks for any input.

@jaswrks
Copy link

@jaswrks jaswrks commented Mar 24, 2016

@yankustefan I'm afraid not. Quick Cache was recently taken offline at WordPress.org in an effort to avoid confusion and to prevent people from downloading Quick Cache, since it is no longer maintained, in favor of ZenCache or Comet Cache.

However, we do have a release archive available that goes back to the first versions of ZenCache and includes all current versions of the newly renamed Comet Cache plugin. See: https://cometcache.com/release-archive/

@yankustefan
Copy link

@yankustefan yankustefan commented Mar 24, 2016

@jaswsinc Thank you for your reply! I bought another licence, so I can download it, and will try if it works and fixes the problem. Cheers!

@raamdev raamdev removed their assignment Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants