Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfiniteWP Support #394

Closed
jaswrks opened this issue Jan 6, 2015 · 15 comments
Closed

InfiniteWP Support #394

jaswrks opened this issue Jan 6, 2015 · 15 comments
Milestone

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Jan 6, 2015

A customer writes...

I use InfiniteWP to manage all my WordPress Installs. IWP checks if the plugins need updating and lets you update all your plugins of all your pages with a single click. QuickCache does not update, I believe, because it needs your username and password. Is there any way to fix this? Is this something the IWP people can fix?

Referencing: https://websharks.zendesk.com/agent/tickets/4759


Related: #395 #394 #465 #289 #464 #352

@colourstone
Copy link

@colourstone colourstone commented Apr 20, 2016

I would love to see this also!! Thank you for the heads up via email Raam! please keep me informed. It's such a pain to go to each site individually and update.

Thank you!
Brent

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 2, 2016

After the work that was done in wpsharks/comet-cache-pro#272 to migrate the Comet Cache Pro Plugin Updater over to the built-in WordPress Plugin Updater, I tried testing a plugin update via InfiniteWP and while the Comet Cache Pro update shows up in InfiniteWP now, updating from the InfiniteWP Dashboard unfortunately still doesn't work:

2016-09-02_17-03-06
2016-09-02_17-23-46
2016-09-02_17-28-25
2016-09-02_17-25-22

The "Return to WordPress Updates page" as the response seems like a clue.

Note that unlike ManageWP (which now works great for remote Comet Cache Pro updates), InfiniteWP is a self-hosted solution that can be downloaded here. It uses the InfiniteWP Client plugin on the WordPress site to communicate between the self-hosted InfiniteWP Dashboard and the WordPress site.

We'll need to do some more testing to get Comet Cache Pro updates compatible with InfiniteWP.

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 8, 2016

@raamdev Did you test this in standard WP or multisite?
Referencing: https://github.com/wp-plugins/iwp-client/blob/1.4.2.2/helper.class.php#L191

Also referencing this filter, which is what CC is attaching to.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 8, 2016

Did you test this in standard WP or multisite?

Standard.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 8, 2016

Noting also that I tested all of this locally. InfiniteWP was installed on my local Vagrant box, which was the same box the WordPress installation was located. I have not tried testing this on an internet-accessible site.

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 8, 2016

Copy that. I tracked down that error message, but I'm not sure how helpful that will be. It seems that it's actually coming from the WP core. https://github.com/WordPress/WordPress/blob/a13164355f15612fa3d4a4367b4b216cc5bafc3f/wp-admin/includes/class-bulk-theme-upgrader-skin.php#L50

I haven't had the chance to test this myself yet. Do you have a screenshot of what is shown by that software when an update is successful?

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 8, 2016

Here's what I get when everything gets updated successfully:
2016-09-08_18-37-35

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 8, 2016

@jaswsinc I just ran this through another test and it seems to be working as expected now... I'm not doing anything different or testing from anywhere new, so I have no explanation for why it's working now.

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 8, 2016

Nice! I'm adding it to my list to test with also. I haven't used this service at all yet.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 9, 2016

@jaswsinc Awesome. If I can get one more confirmation that this is working now, I'll close this and get a changelog added to the current release (currently in the RC phase).

The easiest way I found to test this was to build the dev branch, or even better the release/160908-RC branch, with phing -D project_version=160701 full-build-all, that way the v160709 update is detected and you can test upgrading via InfiniteWP.

@raamdev raamdev added this to the Next Release milestone Sep 9, 2016
@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 9, 2016

I just ran some tests with this. It's working. However, it fooled me once or twice, because there are some PHP notices that seem to cause the sort of unexpected output buffer contents like you posted before. The first time or two I got this.

2016-09-08_18-07-19
2016-09-08_18-07-59

wp-content/debug.log shows...

[09-Sep-2016 02:02:20 UTC] PHP Notice:  Undefined index: activities_log_datetime in /app/src/wp-content/plugins/iwp-client/init.php on line 124
[09-Sep-2016 02:02:20 UTC] PHP Stack trace:
[09-Sep-2016 02:02:20 UTC] PHP   1. {main}() /app/src/wp-admin/index.php:0
[09-Sep-2016 02:02:20 UTC] PHP   2. require_once() /app/src/wp-admin/index.php:10
[09-Sep-2016 02:02:20 UTC] PHP   3. require_once() /app/src/wp-admin/admin.php:31
[09-Sep-2016 02:02:20 UTC] PHP   4. require_once() /app/src/wp-load.php:39
[09-Sep-2016 02:02:20 UTC] PHP   5. require_once() /app/src/wp-config.php:37
[09-Sep-2016 02:02:20 UTC] PHP   6. do_action() /app/src/wp-settings.php:358
[09-Sep-2016 02:02:20 UTC] PHP   7. iwp_mmb_parse_request() /app/src/wp-includes/plugin.php:524

When I take my test installation out of WP_DEBUG mode it works fine.

2016-09-08_18-12-18

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 9, 2016

@jaswsinc Ah, I see. That's helpful. So that looks like an InfiniteWP issue. Otherwise, the Comet Cache Pro Updater integration works fine with InfiniteWP and this can be marked as fixed, correct?

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 9, 2016

Correct. It seems to be working just fine under normal operating conditions.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 9, 2016

Next Release Changelog:

  • InfiniteWP Compatibility (Pro): Comet Cache Pro is now compatible with InfiniteWP, an application that allows you to manage multiple WordPress sites from a single location. Comet Cache Pro Plugin Updates will now appear in the InfiniteWP dashboard and, assuming you have saved valid license credentials in Dashboard → Comet Cache Pro → Plugin Options → Update Credentials, you will be able to upgrade Comet Cache Pro remotely from the InfiniteWP Dashboard. See Issue #394.
@raamdev raamdev closed this Sep 9, 2016
@raamdev raamdev added compatibility and removed needs testing labels Sep 9, 2016
raamdev added a commit that referenced this issue Sep 17, 2016
- **New Feature** (Lite): The Clear Cache button is now available in the Admin Toolbar for the Lite version of Comet Cache.
- **New Feature** (Pro): Comet Cache Pro is now fully compatible with [WordPress Automatic Background Updates](https://codex.wordpress.org/Configuring_Automatic_Background_Updates#Plugin_.26_Theme_Updates_via_Filter). If you enable automatic background updates for plugins, and you save valid Comet Cache Pro License Credentials in the _Comet Cache Pro → Plugin Options → Update Credentials_ panel, you will automatically receive Pro plugin updates. Props @jaswsinc. See [Issue #289](#289).
- **Bug Fix**: In some scenarios Comet Cache might produce a false-positive "Warning: mkdir(): File exists" message when checking if the cache directory exists. Comet Cache now calls `clearstatcache()` and uses `file_exists()` instead of `is_dir()` to help make this check more robust. See [Issue #786](#786).
- **Bug Fix**: Fixed a bug where the Comet Cache PHP requirements check would fail and produce a fatal error when upgrading from a version of Comet Cache that did not require an extension that is now required by newer releases. This would occur when, for example, the required PHP `mbstring` extension was missing. Props @jaswsinc for finding the bug. See [Issue #817](#817).
- **Bug Fix**: Fixed a bug where upgrading from v160521 would result in the Client-Side Cache option being reset to the default (disabled). If you enabled the Client-Side Cache at some point, now is a good time to double-check that it's still enabled. This bug fix also improves the reliability of all version upgrade routines that Comet Cache runs during upgrades. See [Issue #807](#807).
- **Compatibility / Bug Fix**: The automatic Clear Cache routines that cleared the entire cache automatically whenever _WordPress Dashboard → Settings → General_ was updated, were being too aggressive and not taking into consideration other plugins that might also be using the same `options-general.php` URL. As a result, the entire cache was being unnecessarily cleared when the settings for those other plugins were saved. Props to @futtta from Autoptimize for reporting. See [Issue #825](#825).
- **UI Enhancement:** Adjusted option page font styles for WordPress v4.6 to better match existing style. See [Issue #271](wpsharks/comet-cache-pro#271).
- **ManageWP Compatibility** (Pro): Comet Cache Pro is now compatible with ManageWP, a service that allows remote management of multiple WordPress sites. Comet Cache Pro Plugin Updates will now appear in the ManageWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the ManageWP Dashboard. Props @jaswsinc. See [Issue #465](#465).
- **InfiniteWP Compatibility** (Pro): Comet Cache Pro is now compatible with InfiniteWP, an application that allows you to manage multiple WordPress sites from a single location. Comet Cache Pro Plugin Updates will now appear in the InfiniteWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the InfiniteWP Dashboard. See [Issue #394](#394).
- **Rewritten Pro Plugin Updater**: The Comet Cache Pro Plugin Updater has been redesigned to use the built-in WordPress plugin updater system. When a Comet Cache Pro update is available, it now appears in the WordPress Updates section and in the Plugins list, like other WordPress plugins and can be updated normally like other WordPress plugins, as long as you have saved valid Comet Cache Pro license details in the new "Update Credentials" options panel. Props @jaswsinc. See [Issue #272](wpsharks/comet-cache-pro#272).
- **Code Style**: The `WP_CACHE` line that gets inserted into the `wp-config.php` file to enable caching now follows the [WordPress PHP Code Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/). Props @szepeviktor. See [Issue #799](#799).
- **Compatibility** (Pro): When the Autoptimize plugin is active, the Comet Cache Pro HTML Compressor panel now shows a friendly notice explaining that both the HTML Compressor and Autoptimize should not be enabled at the same time because they both address the same performance improvements. The rest of Comet Cache works great alongside Autoptimize and whether you use the HTML Compressor or Autoptimize is a matter of preference. Props to @futtta from Autoptimize for the continued collaboration.
@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 17, 2016

Comet Cache v160917 has been released and includes changes from this GitHub Issue. See the v160917 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#394).

@wpsharks wpsharks locked and limited conversation to collaborators Sep 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.