Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zencache\cdn_filters::filter_url() Requires PHP v5.4+ #426

Closed
jaswrks opened this issue Mar 2, 2015 · 12 comments
Closed

zencache\cdn_filters::filter_url() Requires PHP v5.4+ #426

jaswrks opened this issue Mar 2, 2015 · 12 comments

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Mar 2, 2015

I got a report about Static CDN Filters not running as expected on PHP v5.3, due to a protected method that is called from an anonymous/unsupported context in PHP v5.3. That's news to me!

Call to protected method zencache\cdn_filters::filter_url() from context ''

So for the moment, it would appear that Static CDN Filters require PHP v5.4+.


Suggested change: Make this a public method in the next release of ZenCache Pro.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 3, 2015

I'm labeling this as a bug since the Static CDN Filters feature is currently broken with PHP v5.3.

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Mar 3, 2015

I've had this corrected. I'll submit a Pull Request once the repo changeover is done.

@skipthedrive
Copy link

@skipthedrive skipthedrive commented Mar 5, 2015

Thanks for looking into this, guys!

@skipthedrive
Copy link

@skipthedrive skipthedrive commented Mar 6, 2015

Hey Guys -

I wanted to give you an updated. I called my hosting provider and had them upgrade my PHP version to 5.4. I verified (with one of my plugins) that the version I am running is 5.4.19. I then enabled CDN using the default settings (no exclusions/inclusions), and added my CDN host name. I got the same error message.

Pete

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Mar 6, 2015

got the same error message.

Thank you for the feedback @skipthedrive ~ I thought it was strange. I'm taking a closer look at this so I can see exactly which version is in conflict here.

@skipthedrive
Copy link

@skipthedrive skipthedrive commented Mar 6, 2015

No problem @jaswinc . Would SSL conflict with the CDN in any way?

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Mar 6, 2015

My detailed tests here demonstrate that PHP v5.4.0 is all that's required to get this working. Notice that PHP versions 5.4.0+ all produce the expected hello output here: http://3v4l.org/8HLW5

I verified (with one of my plugins) that the version I am running is 5.4.19. I then enabled CDN using the default settings (no exclusions/inclusions), and added my CDN host name.

Interesting. That seems not possible based on the tests that I just ran. I'll leave this open.

@skipthedrive
Copy link

@skipthedrive skipthedrive commented Mar 6, 2015

OK, thanks for the update.

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Mar 7, 2015

@raamdev Here is a version of the same test that succeeds on PHP v5.3+. Notice here that I changed the protected method to a public method. That's what the related PR does too.

http://3v4l.org/J7gnO

@raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 7, 2015

@jaswsinc Thank you!

This has been merged into the development trunk and will go out with the next release:

  • Bug Fix (Pro): The Static CDN Filters feature was calling a protected method that was requiring PHP v5.4+ but now the Static CDN Filters feature works with PHP v5.3+. See #426.
@raamdev raamdev closed this Mar 7, 2015
@raamdev raamdev added this to the Next Release milestone Mar 7, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 12, 2015

This has been fixed in the development trunk and the next release of ZenCache will include this fix.

  • Bug Fix (Pro): The Static CDN Filters feature was calling a protected method that was requiring PHP v5.4+ but now the Static CDN Filters feature works with PHP v5.3+. See #426.
@skipthedrive
Copy link

@skipthedrive skipthedrive commented Mar 12, 2015

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants