Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstalling Quick Cache after migrating to ZenCache results in missing `define('WP_CACHE', TRUE)` #450

Closed
raamdev opened this issue Mar 23, 2015 · 3 comments
Labels
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 23, 2015

In v150314 we fixed a zero-byte advanced-cache.php bug related to uninstalling Quick Cache after migrating over to ZenCache (see #432). However, it seems that uninstalling Quick Cache is also removing the define('WP_CACHE', TRUE); from the wp-config.php file.

So, even though ZenCache is now ensuring that advanced-cache.php is populated and correct, the cache is not being used because define('WP_CACHE', TRUE); is missing from wp-config.php.

It looks like we just need to add a call to add_wp_cache_to_wp_config() inside check_advanced_cache() right here, so that whenever the advanced-cache.php file is missing or empty we also check to make sure define('WP_CACHE', TRUE); is set in the wp-config.php file.

@jaswsinc Does that sound right to you?

@raamdev raamdev added the bug label Mar 23, 2015
@raamdev raamdev added this to the Next Release milestone Mar 23, 2015
@jaswrks
Copy link

@jaswrks jaswrks commented Mar 23, 2015

@raamdev writes...

Does that sound right to you?

Good catch! Sounds good to me.

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Mar 23, 2015

Next release changelog:

  • Bug Fix: Fixed a bug related to the Quick Cache migration that resulted in caching being disabled despite ZenCache being enabled. Uninstalling Quick Cache was removing define('WP_CACHE', TRUE); from the wp-config.php file. ZenCache now makes sure that caching remains enabled after uninstalling Quick Cache during the ZenCache migration process. Issue #450.
@raamdev raamdev closed this Mar 23, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Apr 10, 2015

This fix has been released with ZenCache v150409:
http://zencache.com/zencache-v150409-now-available/

If you need to follow-up with something related to this GitHub Issue, please open a new GitHub Issue.

@wpsharks wpsharks locked and limited conversation to collaborators Apr 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants