Skip to content

/ comet-cache

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim() expects parameter 1 to be string #455

Closed
raamdev opened this issue Mar 27, 2015 · 2 comments
Closed

trim() expects parameter 1 to be string #455

raamdev opened this issue Mar 27, 2015 · 2 comments
Labels
bug
Milestone
v150409

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 27, 2015

Some users report seeing the following warning in the WordPress Dashboard:

Warning: trim() expects parameter 1 to be string, array given in /home/..../wp-content/plugins/zencache-pro/zencache-pro.inc.php on line 967

Line 967 in zencache-pro.inc.php: https://github.com/websharks/zencache-pro/blob/000000-dev/zencache-pro/zencache-pro.inc.php#L967

@jaswsinc writes...

That is a bug. The call to array_map('trim', assumes that $_REQUEST will contain all scalar values. A new method should be added (it may already exist), called trim_deep().
@raamdev raamdev added the bug label Mar 27, 2015
@raamdev raamdev added this to the Next Release milestone Mar 27, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Mar 27, 2015
@raamdev
Fix bug with assumption that `$_REQUEST` will contain all scalar values
a628e8d 
See wpsharks/comet-cache#455
@raamdev raamdev mentioned this issue Mar 27, 2015
Closed
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Mar 27, 2015
@raamdev
Use proper call to `trim_deep()`. See wpsharks/comet-cache#455
4e5e455
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Mar 27, 2015

Next release changelog:

  • Bug Fix (Pro): Some users reported seeing Warning: trim() expects parameter 1 to be string. This was produced by a low-impact bug that has been fixed in this release. Issue #455.
@raamdev raamdev closed this Mar 27, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Apr 10, 2015

This fix has been released with ZenCache v150409:
http://zencache.com/zencache-v150409-now-available/

If you need to follow-up with something related to this GitHub Issue, please open a new GitHub Issue and provide a link back to this Issue.
@wpsharks wpsharks locked and limited conversation to collaborators Apr 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v150409
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@raamdev