Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug :: Multisite :: ACE :: Option Storage #543

Closed
jaswrks opened this issue Aug 11, 2015 · 3 comments
Closed

Bug :: Multisite :: ACE :: Option Storage #543

jaswrks opened this issue Aug 11, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Aug 11, 2015

Overview

The ACE is supposed to run only from the Main Site. This strategy has actually changed a bit since the original creation of the ACE. Over time, we have improved the ACE, and now it really should only be running from the Main Site in a network. It currently does not; i.e., BUG.

Steps to Reproduce

  • Enable ZenCache network wide in a MS installation.
  • Enable the ACE & and setup an XML sitemap for at least one child blog.
  • Visit each of the child blogs and run: /?zencache_auto_cache_cron=1 from each of them.

Expected Behavior

That the ACE would not run on the child blog.

Observed Behavior

The ACE is currently allowed to run from the child blog. In fact, the setup() routine in ZenCache is currently configuring multiple CRON jobs; i.e., for each child blog. That's a bug. It also has the potential to create a process overlap which could lead to performance issues.

@jaswrks jaswrks added bug pro labels Aug 11, 2015
@jaswrks jaswrks self-assigned this Aug 11, 2015
@jaswrks
Copy link
Author

@jaswrks jaswrks commented Aug 11, 2015

The ACE is currently allowed to run from the child blog. In fact, the setup() routine in ZenCache is currently configuring multiple CRON jobs; i.e., for each child blog. That's a bug. It also has the potential to create a process overlap which could lead to performance issues.

This only happens in a specific scenario. It's not a widespread issue. However, it needs to be fixed nonetheless. My feeling is that data storage in ZenCache needs to use *_site_option() exclusively whenever work to correct this bug occurs.

@raamdev raamdev added the multisite label Aug 12, 2015
@raamdev raamdev added this to the Future Release (Pro) milestone Aug 12, 2015
@raamdev raamdev closed this Sep 17, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 18, 2015

Next Pro Release Changelog:

  • Multisite Bug Fix: Fixed a bug in the Auto-Cache Engine that was resulting in duplicate Cron Jobs being created for each Child Site. The Auto-Cache Engine now only runs from the Main Site in a network, as it should. When the Auto-Cache Engine runs on the Main Site, it will also run for each of the Child Blogs (see this article for more information). Props @jaswsinc. See Issue #543.
@raamdev
Copy link
Contributor

@raamdev raamdev commented Oct 2, 2015

ZenCache Pro v151002 has been released and includes changes from this GitHub Issue.

See the ZenCache Pro v151002 release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#543).

@wpsharks wpsharks locked and limited conversation to collaborators Oct 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants