Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude .sass and .map files from distributable zip #579

Closed
bridgeport opened this issue Oct 2, 2015 · 7 comments
Closed

Exclude .sass and .map files from distributable zip #579

bridgeport opened this issue Oct 2, 2015 · 7 comments
Labels
Milestone

Comments

@bridgeport
Copy link

@bridgeport bridgeport commented Oct 2, 2015

The latest ZenCache pro v151002 looks great. The stats section and admin bar are very slick and informative.

However, it looks like it was packaged with the .sass and .map files. An oversight perhaps?

Location of the .sass files and directories:

zencache-pro/src/client-s/css/admin-bar.scss
zencache-pro/src/client-s/css/menu-pages.scss

zencache-pro/src/client-s/css/admin-bar/*
zencache-pro/src/client-s/css/menu-pages/*
zencache-pro/src/vendor/package/bourbon/*
zencache-pro/src/vendor/package/*

Location of the .map files:

zencache-pro/src/client-s/css/admin-bar.min.css.map
zencache-pro/src/client-s/css/menu-pages.min.css.map
zencache-pro/src/vendor/websharks/sharkicons/src/long-classes.min.css.map
zencache-pro/src/vendor/websharks/sharkicons/src/short-classes.min.css.map
@raamdev
Copy link
Contributor

@raamdev raamdev commented Oct 3, 2015

@bridgeport Thanks for the reminder. :-) We'll work towards updating our build script to exclude those files. You're right that they're not needed in the distributable zip.

@raamdev raamdev changed the title ZenCache Pro v151002 shipped with .sass and .map files Exclude .sass and .map files from distributable zip Oct 3, 2015
@raamdev raamdev added pro todo labels Oct 3, 2015
@raamdev raamdev modified the milestones: Next Release (Pro), Future Release (Pro) Oct 3, 2015
@jaswrks
Copy link

@jaswrks jaswrks commented Oct 7, 2015

Next Actions

  • New feature branch: feature/579 in the websharks/phings repo.

  • After this line add the following.

    <exclude name="vendor/**.scss" />
    <exclude name="**/vendor/**.scss" />
    
    <exclude name="vendor/**.css.map" />
    <exclude name="**/vendor/**.css.map" />
    
    <exclude name="vendor/package/bourbon/**" />
    <exclude name="**/vendor/package/bourbon/**" />
  • After this line repeat the same exclusions.

  • Submit PR.

@jaswrks
Copy link

@jaswrks jaswrks commented Oct 7, 2015

@raamdev While working on this issue you can take note of the FileSet tag provided by Phing and learn more about how ** is interpreted by Phing: https://www.phing.info/docs/guide/trunk/FileSet.html

@raamdev
Copy link
Contributor

@raamdev raamdev commented Oct 10, 2015

Noting that this GitHub Issue should not be closed until the ZenCache Pro repo has been updated to include the latest build script changes (namely everything from wpsharks/phings#15, but also the changes from wpsharks/phings#17 which addresses this particular GitHub Issue).

GitHub Issue to track updating ZenCache Pro with latest Phing build script is here: https://github.com/websharks/zencache.com/issues/72

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Nov 1, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Nov 2, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 5, 2015

Build script has been updated and I've confirmed that the .sass and .map files (along with some other unnecessary files) are excluded from the distributable zip. The next release will have these files excluded. :-)

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 5, 2015

Next Pro Release Changelog:

  • Enhancement: Excluded several unnecessary files from the plugin zip file that were being used during the build process but were not necessary to run the plugin. Props @bridgeport. See Issue #579.
@raamdev raamdev closed this Nov 5, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 14, 2015

ZenCache v151114 has been released and includes changes from this GitHub Issue. See the v151114 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#579).

@wpsharks wpsharks locked and limited conversation to collaborators Nov 14, 2015
@raamdev raamdev removed their assignment Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants