Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Cache Engine XML Sitemap Error Notice Only Shows Once Every 15 Minutes #616

Closed
raamdev opened this issue Nov 18, 2015 · 7 comments
Closed

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 18, 2015

The Auto-Cache Engine currently displays a Dashboard notice whenever the configured XML Sitemap location is not accessible; see src/includes/classes/AutoCache.php#L246-L258

2015-11-17_20-12-45

However, the notice is not intelligent: If the site owner empties the XML Sitemap field as described in the notice, ZenCache does not detect that this has been done and clear the error notice as would be expected. It also takes a full 15 minutes (until the Auto-Cache Engine runs again) for a dismissed error to reappear, which temporarily misleads the site owner into thinking the problem might be fixed.

What needs to happen to improve this:

  • Don't make this error notice dismissable--the only way to get rid of the notice should be:
    • Disable the Auto-Cache Engine
    • Fix the issue with the sitemap being unreachable (e.g., install an XML Sitemap plugin, or correct the name of the XML Sitemap)
    • Clear the XML Sitemap field altogether
  • Detect when the problem has been fixed; note that right now this problem is only checked when the Auto-Cache Engine runs, i.e., once every 15 minutes. This error should be checked on every admin_init and cleared as soon as the problem goes away (see previous point).
@raamdev raamdev added this to the Next Release (Pro) milestone Nov 18, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 18, 2015

Related issues: #615 #555

@raamdev raamdev added bug and removed todo labels Nov 18, 2015
@raamdev raamdev changed the title Improve Auto-Cache Engine XML Sitemap Error Notice Fix Auto-Cache Engine XML Sitemap Error Notice Nov 18, 2015
@raamdev raamdev changed the title Fix Auto-Cache Engine XML Sitemap Error Notice Auto-Cache Engine XML Sitemap Error Notice Only Works Once Nov 18, 2015
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 18, 2015

However, if a site owner dismisses that message, they will never see it again! That sort of defeats the purpose of that entire feature as there's no way to tell if the problem has been fixed or if the problem returns

Why do you say that they will never see it again? Unless I am missing something, if you dismiss the notice, but the error occurs again, the notice comes back each time. You must dismiss the notice each time the error occurs.

Detect when the problem has been fixed; note that right now this problem is only checked when the Auto-Cache Engine runs, i.e., once every 15 minutes. This error should be checked on every admin_init

Agree.

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 18, 2015

Why do you say that they will never see it again? Unless I am missing something, if you dismiss the notice, but the error occurs again, the notice comes back each time. You must dismiss the notice each time the error occurs.

Hmm, you're right. When I initially tested this, dismissing the notice did not seem to remove the notice from the database, however I just tested it again and this time I see that dismissing the notice removes it from the database and therefore the next time this error occurs, the notice reappears.

I've updated the GitHub issue above to reflect only the changes necessary to improve this notice and make it more intelligent.

@raamdev raamdev changed the title Auto-Cache Engine XML Sitemap Error Notice Only Works Once Auto-Cache Engine XML Sitemap Error Notice Only Shows Once Every 15 Minutes Nov 18, 2015
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 19, 2015

Cool. Copy that.

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 22, 2015

Related: #618

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 3, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 3, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 4, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 4, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 4, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 4, 2015

Next Pro Release Changelog:

  • Enhancement: Auto-Cache Engine XML Sitemap error checking is now more intelligent. When configured, the XML Sitemap URL is now checked upon every admin_init to verify that the XML Sitemap is accessible and valid. If a previous error has been fixed, the error message will disappear immediately instead of taking 15 minutes (the Auto-Cache Engine run cycle). See Issue #616.
@raamdev raamdev closed this Dec 4, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 21, 2015

ZenCache Pro v151220 has been released and includes changes worked on as part of this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#616).

@wpsharks wpsharks locked and limited conversation to collaborators Dec 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants