Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Using `define('ZENCACHE_ALLOWED', FALSE);` to Disable Zencache, Should Disable the ZenCache Static CDN Filters #628

Closed
renzms opened this issue Dec 2, 2015 · 2 comments

Comments

@renzms
Copy link

@renzms renzms commented Dec 2, 2015

Overview

Customer tried using `define('ZENCACHE_ALLOWED', FALSE); to disable CDN support for specific pages, but was not working properly.

Steps to Reproduce

  • Set define('ZENCACHE_ALLOWED', FALSE); or define('DONOTCACHEPAGE', TRUE);
  • Check if Static CDN Filters/ZenCache itself are disabled

Expected Behavior

Setting define('ZENCACHE_ALLOWED', FALSE); or define('DONOTCACHEPAGE', TRUE); should disable the ZenCache Static CDN Filters as well as the caching itself. There should probably be a separate constant to allow for specifically disabling Static CDN Filters and the HTML Compressor (e.g., ZENCACHE_CDN_ALLOWED and ZENCACHE_HTMLC_ALLOWED).

Observed Behavior

Customer reported that they tried to disable CDN support for specific pages. They were using define('ZENCACHE_ALLOWED', FALSE); to disable Zencache, but reported that it still uses static CDN if globally enabled.

_

referenced in internal ticket: https://websharks.zendesk.com/agent/tickets/9784

@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 5, 2015

Next Pro Release Changelog:

  • Enhancement: The Static CDN Filters now attempt to obey the ZENCACHE_ALLOWED and DONOTCACHEPAGE constants so that Static CDN Filters are not applied when caching is disabled. However, due to the way Static CDN Filters are implemented this is not always reliable. If you need to programmatically disable Static CDN Filters, see this article. See Issue #628.
@raamdev raamdev closed this Dec 5, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 21, 2015

ZenCache v151220 has been released and includes changes worked on as part of this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#628).

@wpsharks wpsharks locked and limited conversation to collaborators Dec 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants