Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter to disable `_wpnonce` exclusion #637

Closed
raamdev opened this issue Dec 21, 2015 · 8 comments
Closed

Filter to disable `_wpnonce` exclusion #637

raamdev opened this issue Dec 21, 2015 · 8 comments
Labels
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 21, 2015

In v151220, we prevented pages that include _wpnonce in their HTML from being cached (see #601). I have seen several requests now for the ability to disable this functionality and allow _wpnonce in the HTML source.

We should add a filter to make this possible, and write a KB Article that explains how to use the filter and the risks of doing so.

@raamdev raamdev added the enhancement label Dec 21, 2015
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 27, 2015
Does not include a UI but can be controlled via `define('ZENCACHE_CACHE_NONCE_VALUES', TRUE);` in `wp-config.php`

See wpsharks/comet-cache#637
@raamdev raamdev added this to the Next Release (Pro) milestone Dec 27, 2015
@kristineds
Copy link

@kristineds kristineds commented Dec 28, 2015

Also requested here (referencing internal, private ticket): https://websharks.zendesk.com/agent/tickets/10280

@kristineds
Copy link

@kristineds kristineds commented Dec 28, 2015

Requested here as well (internal, private ticket): https://websharks.zendesk.com/agent/tickets/10204

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 28, 2015

Also requested here (internal ticket): https://websharks.zendesk.com/agent/tickets/10258

@viriis
Copy link

@viriis viriis commented Dec 28, 2015

Hi, How can I access to the link because I have this message
"You do not have access to request #10258. It may have been solved or deleted."
Thanks

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 29, 2015

Hi, How can I access to the link because I have this message
"You do not have access to request #10258. It may have been solved or deleted."

@viriis Those are private, internal tickets, not publicly accessible.

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 30, 2015

Also requested here (internal, private ticket): https://websharks.zendesk.com/agent/tickets/10283

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jan 2, 2016
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Jan 3, 2016

Next Pro Release Changelog:

  • Enhancement: It's now possible to override the ZenCache Nonce exclusion globally (dangerous) or only for Logged-In Users (safer). Please see this article for full details. Issue #637.
@raamdev raamdev closed this Jan 3, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Jan 3, 2016
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Jan 3, 2016

ZenCache Pro v160103 has been released and includes changes from this GitHub Issue. See the v160103 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#637).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants