Run setup() on plugins_loaded instead of after_setup_theme

[raamdev]

Comet Cache currently hooks its setup routine into after_theme_setup, which runs after plugins_loaded.

Other plugins that integrate with Comet Cache might hook into plugins_loaded to make API calls like comet_cache::clear(), which would currently fail with a fatal error because the setup routine hasn't been run yet:

PHP Fatal error: Uncaught exception 'Exception' with message 'Missing base_dir option value.'

We should take a closer look at this and use the plugins_loaded hook instead if possible.

---

Referencing: https://wordpress.org/support/topic/clearing-cache-from-autoptimize-base_dir-option

[raamdev]

@jaswsinc Is there any reason we're hooking into after_setup_theme here and not plugins_loaded? I reviewed the setup() function and I'm not seeing anything in there that would require waiting until after_theme_setup.

[jaswrks]

No, that sounds fine to me also.

[raamdev]

Next Release Changelog:

• Hooks/Filters: Comet Cache now hooks into plugins_loaded instead of after_setup_theme when calling its own setup routine. This improves integration with other plugins that may be expecting the Comet Cache API functions to be available after plugins_loaded. Props to Frank Goossens (@futtta) from Autoptimize for helping with this. See Issue #716.

[raamdev]

Comet Cache v160416 has been released and includes changes from this GitHub Issue. See the v160416 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#716).