Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comet Cache v160629-RC (Release Candidate) #792

Closed
raamdev opened this issue Jun 29, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@raamdev
Copy link
Contributor

commented Jun 29, 2016

This GitHub issue serves as a place to discuss and report issues with Comet Cache v160629-RC. The next General Availability release is currently scheduled for July 6th, 2016.

Downloads

Changelog

Reporting Issues / Feedback

Please report any issues or feedback related to this Release Candidate using this GitHub issue. Please post a comment below with details.

If you are reporting a UI-related issue, please include a screenshot.

If you are reporting a bug, please provide list of steps to reproduce and if the bug is related to an existing GitHub issue, please provide a link to that GitHub issue as well.


Issues to Fix

  • RewriteBase / in .htaccess should match-up with the WordPress installation sub-directory. #792 (comment)
  • Facebook/Twitter links don't show up on Pro Updater and Stats/Charts options pages. #792 (comment)

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jun 29, 2016

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jun 29, 2016

@raamdev raamdev added the todo label Jun 29, 2016

@raamdev raamdev added this to the Next Release milestone Jun 29, 2016

@jaswrks

This comment has been minimized.

Copy link

commented Jun 30, 2016

Fixed in wpsharks/comet-cache-pro@dc9d632 and wpsharks/comet-cache-pro@5842c83.


RewriteBase / in .htaccess should match-up with the WordPress installation sub-directory. Installing Comet Cache and enabling Apache Optimizations in a sub-directory installation results in broken redirections. Referencing: https://github.com/websharks/comet-cache-pro/blob/160629-RC/src/includes/templates/htaccess/canonical-urls-no-ts-enable.txt#L4

See also comment & examples referenced here.

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jul 5, 2016

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jul 6, 2016

@renzms

This comment has been minimized.

Copy link

commented Jul 6, 2016

Fixed in wpsharks/comet-cache-pro@5842c83...6bf5dac.


Tested Social Media Links in Pro and Lite

On the main menu page it shows up fine and works

Main Comet Cache Menu page:
screen shot 2016-07-06 at 8 11 19 am

They don't appear on the Stats Page and Plugin Pro Updater Page. (I must have forgotten this in: #771)

screen shot 2016-07-06 at 8 11 11 am
screen shot 2016-07-06 at 8 11 02 am

@renzms

This comment has been minimized.

Copy link

commented Jul 6, 2016

Also, in regards to Comment Mail settings, when updating settings is their supposed to be a notification about the cache clearing because of Comment Mail in Comet Cache, or is this done "quietly"?

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jul 6, 2016

@raamdev

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2016

@renzms writes...

Also, in regards to Comment Mail settings, when updating settings is their supposed to be a notification about the cache clearing because of Comment Mail in Comet Cache, or is this done "quietly"?

It's not quiet—there's a notification from Comet Cache whenever the cache is cleared (for any reason, as long as you haven't manually disabled notifications in Comet Cache → Plugin Options → Automatic Cache Clearing (Pro-only)).

I just confirmed the clearing of the cache whenever there is a change to Comment Mail settings is working as expected. The key thing to note is that you must actually have something in the cache to be cleared, and you must actually change a Comment Mail setting (simply hitting Save All Changes at the bottom isn't enough, as that doesn't actually result in anything changing unless you actually modify an option).

2016-07-05_20-26-58

@jaswrks

This comment has been minimized.

Copy link

commented Jul 6, 2016

Fixed in wpsharks/comet-cache-pro@2dc6e73.


@raamdev writes...

Fixed in wpsharks/comet-cache-pro@dc9d632 and wpsharks/comet-cache-pro@5842c83.

Does this also cover the case where a site owner copies the snippet and inserts it on their own?

2016-07-06_08-21-23

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jul 6, 2016

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Jul 7, 2016

@raamdev

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2016

Comet Cache v160706 Now Available: https://cometcache.com/blog/comet-cache-v160706-now-available/

@websharks/comet-cache-team Thanks for all the help testing! :-)

@raamdev raamdev closed this Jul 7, 2016

@wpsharks wpsharks locked and limited conversation to collaborators Jul 7, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.