Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro upgrade notice is not dismissed when upgrading via FTP #806

Closed
raamdev opened this issue Jul 12, 2016 · 8 comments
Closed

Pro upgrade notice is not dismissed when upgrading via FTP #806

raamdev opened this issue Jul 12, 2016 · 8 comments

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jul 12, 2016

If you upgrade Comet Cache Pro via FTP, the Dashboard notice that announces a new version is available does not get automatically dismissed.

2016-07-12_16-53-07

There needs to be a routine that dismisses any upgrade notice if the current version installed is detected as the latest version.

@raamdev raamdev added this to the Next Release milestone Jul 12, 2016
@raamdev raamdev self-assigned this Aug 24, 2016
@raamdev raamdev removed this from the Next Release milestone Sep 6, 2016
@raamdev raamdev added this to the Future Release milestone Sep 6, 2016
@raamdev raamdev added this to the Future Release milestone Sep 6, 2016
@raamdev raamdev removed this from the Next Release milestone Sep 6, 2016
@raamdev raamdev removed their assignment Oct 11, 2016
@jaswrks
Copy link

@jaswrks jaswrks commented Oct 11, 2016

Estimate .25 days.

Loading

@jaswrks
Copy link

@jaswrks jaswrks commented Nov 8, 2016

Related comment: #829 (comment)

Loading

jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Nov 8, 2016
…ons whenever a new version of the software is recompiled; i.e., don't continue to show an upgrade notice whenever the software has just been updated by a site owner. See also: [issue #806](wpsharks/comet-cache#806) if you'd like additional details.
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 8, 2016

Next Release Changelog:

  • Bug Fix: Automatically dismiss any persistent update notifications whenever a new version of the software is recompiled; i.e., don't continue to show an upgrade notice whenever the software has just been updated by a site owner. See also: issue #806 if you'd like additional details.

Loading

@jaswrks
Copy link

@jaswrks jaswrks commented Nov 8, 2016

Noting also that these update notifications that are being cleared no longer exist in the current release of the software. The automatic clearing of these persistent notifications is to clear them on old installations of Comet Cache.

Loading

@renzms
Copy link

@renzms renzms commented Nov 13, 2016

@jaswsinc

screen shot 2016-11-13 at 7 05 23 pm

Built from the current dev branch and ran phing -D project_version=160701 full-build-all to backdate, but no update available shows in the header. Is this the correct way to test this?

Loading

@jaswrks
Copy link

@jaswrks jaswrks commented Nov 13, 2016

@renzms You'd need to actually install one of the older builds where that notification was posted to the Dashboard. The newer builds, like those from the dev branch, don't do this, even if you backdate the build. It's still from the newer source code that doesn't post that notice.

Loading

@renzms
Copy link

@renzms renzms commented Nov 16, 2016

@jaswsinc

Thanks!

@raamdev

Confirmed working in Comet Cache v161116-RC / Pro

Tested using Comet Cache 160412 / Pro and upgraded via FTP using Comet Cache v161116-RC / Pro. Update notice is removed after uploading via FTP.

screen shot 2016-11-16 at 10 25 13 pm

Loading

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 19, 2016

Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#806).

Loading

@raamdev raamdev closed this Nov 19, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Nov 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants