Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update Available" shows in header but no update shows in Plugin updater #829

Closed
renzms opened this issue Sep 14, 2016 · 4 comments
Closed

"Update Available" shows in header but no update shows in Plugin updater #829

renzms opened this issue Sep 14, 2016 · 4 comments

Comments

@renzms
Copy link

@renzms renzms commented Sep 14, 2016

While testing the new features: ManageWP Compatibility + Automatic Updates (see: Comet Cache v160908-RC (Release Candidate), I observed an inconsistency with the update notifications. In the Plugin Options of Comet Cache Pro the header would say update available, but no update for the plugin would show in the Plugin updater list. By extension, it did not appear in the ManageWP Dashboard for list of Plugins to be updated.

Steps to reproduce:

  • Make sure your existing WP installation does not have Comet Cache Pro 160908-RC settings saved. If so, please disable Plugin Deletion Safeguard Options to wipe settings upon deletion.
  • Checkout release/160908 Comet Cache Pro branch, then run phing -D project_version=160701 full-build-all
  • Upload and install Comet Cache Pro v160701
  • Wait a few moments before adding the Update Credentials after installing and activating the plugin.

Observed Behavior:

  • In the header for Comet Cache Pro, it will indicate an update is available, (v160709).

"Update Available" in header:
screen shot 2016-09-14 at 6 50 17 am

  • In the plugins list, it will not indicate any available update

No update in Plugins list
screen shot 2016-09-14 at 7 56 44 am

  • In ManageWP the plugins update list does not show Comet Cache Pro with any available update

ManageWP Dashboard:
screen shot 2016-09-14 at 7 35 38 am

  • Forcing WordPress to Check Again via the Updates list would sometimes cause it to trigger the update, other times not
  • Waiting exactly 1 hr, will trigger the update in the Plugins list if it doesn't initially appear after installation.

Expected behavior:

  • Comet Cache should show update available in header, Plugins list, and ManageWP Dashboard.

2016-09-13_19-38-00

screen shot 2016-09-14 at 8 23 56 am

@raamdev
Copy link
Contributor

@raamdev raamdev commented Oct 11, 2016

I suggest that we simply remove the "(update available)" from the plugin options menu to resolve this issue. Now that we're integrating with the WordPress Update mechanism, there are already plenty of places that will indicate an update is available. I don't think it's necessary to also show it on the plugin options page.

jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Nov 8, 2016
jaswsinc
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 8, 2016

Next Release Changelog:

  • UI Enhancement: Following improvements to the update API in a previous release of Comet Cache that made it possible to update both the lite and pro versions of the software through normal WordPress update mechanisms, this release removes some clutter from the menu pages for Comet Cache. In short, now that we have a tighter integration with WordPress core, it's no longer necessary for Comet Cache to display update notifications in a custom way. See also issue #829 for further details.
@renzms
Copy link
Author

@renzms renzms commented Nov 13, 2016

@jaswsinc

Attempted testing this, see comment here

@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 19, 2016

Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#829).

@raamdev raamdev closed this Nov 19, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Nov 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants