Chart.js should not be enqueued in Lite version #830
Closed
Comments
jaswrks
pushed a commit
to wpsharks/comet-cache-pro
that referenced
this issue
Nov 8, 2016
…f the sofware. See also: [issue #830](wpsharks/comet-cache#830) if you'd like additional details.
Next Release Changelog:
|
Confirmed WorkingChart.js only loaded in the Pro version. PRO: LITE: |
Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#830). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In Comet Cache v160917 we included the Clear Cache button in the Admin Toolbar for the Lite version of Comet Cache (previously this was a Pro-only feature). As part of that work, the
Chart.js
was unnecessarily allowed to be included in the Lite verison here and here — this is unncessary asChart.js
is only used by the Comet Cache Stats/Charts feature (still a Pro-only feature).We should avoid enqueueing
Chart.js
in the Lite version not only because it's not being used but because it can cause problems with other plugins that might be using a different version ofChart.js
, as seen in the report below.Pär Thernström, plugin author for the Simple History plugin (30k+ active installs) says:
Note that this has also been cross-referenced on the Comet Cache support forum.
The text was updated successfully, but these errors were encountered: