Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate.wordpress.org missing string from /src/includes/traits/Plugin/NoticeUtils.php#L189 #831

Closed
raamdev opened this issue Sep 21, 2016 · 4 comments
Assignees
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 21, 2016

The translate.wordpress.org site doesn't seem to be picking up the string translated on this line for Comet Cache Lite:
https://github.com/websharks/comet-cache/blob/160917/src/includes/traits/Plugin/NoticeUtils.php#L189

I suspect this is because that translated string contains JavaScript. There's no good reason for the string to contain JavaScript and that could be moved outside of the translation function (__()).

@raamdev raamdev added this to the Next Release milestone Sep 21, 2016
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Nov 8, 2016
jaswsinc
…t allows you to see additional details whenever Comet Cache automatically clears more than one facet of the cache. See also [issue #837](wpsharks/comet-cache#837) and [issue #831](wpsharks/comet-cache#831) if you'd like additional details.
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 8, 2016

Next Release Changelog:

  • Minor UI Enhancement: This release improves the toggle link that allows you to see additional details whenever Comet Cache automatically clears more than one facet of the cache. See also issue #837 and issue #831 if you'd like additional details.
@jaswrks
Copy link

@jaswrks jaswrks commented Nov 8, 2016

2016-11-08_09-10-22

@renzms
Copy link

@renzms renzms commented Nov 11, 2016

@raamdev

Confirmed minor change is working.

screen shot 2016-11-11 at 10 12 26 pm

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 19, 2016

Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#831).

@raamdev raamdev closed this Nov 19, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Nov 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants