New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comet Cache v161214-RC (Release Candidate) #858

Closed
raamdev opened this Issue Dec 14, 2016 · 12 comments

Comments

Projects
None yet
4 participants
@raamdev
Copy link
Contributor

raamdev commented Dec 14, 2016

General Availability Target: December 16th, 2016

Downloads

Changelog

  • Bug Fix: Improving OPcache detection. Now considering INI option opcache.restrict_api. Comet Cache is now smart enough to avoid the error: PHP Warning: Zend OPcache API is restricted by "restrict_api" configuration directive. See Issue #733.

  • New Feature (Pro): Mobile Mode. This release adds a new feature that is designed to improve compatibility with Adaptive themes for mobile devices. To learn more, please see: Dashboard → Comet Cache Pro → Plugin Options → Mobile-Adaptive Mode. See also: Issue #471 and the screenshots here.

  • Enhancement: Auto-Clearing Author Page Cache. This release makes Comet Cache smart enough to detect when a user is deleted (or removed from a child blog in a Network), at which time the Author page for that user will be cleared from the cache so it can be regenerated automatically. See Issue #304.

  • Enhancement: Multibyte Compatibility. This release improves support for WordPress Permalinks that contain UTF-8 symbols (or emojis) in them. More specifically, this release adds the /u flag to all preg_*() calls in cache clearing routines that generate cache paths from Watered-Down Regex patterns entered by a site owner. See: Issue #611.

  • Enhancement: Widget Change Detection. Comet Cache can now detect when Appearance → Widgets are added/edited/removed, and Comet Cache will automatically clear the cache so that your site remains up-to-date. See Issue #411.

  • Enhancement (Pro): Static CDN Filters and srcset. This release enhances Static CDN Filters in Comet Cache Pro. Static CDN Filters are now smart enough to filter all image sources included in an srcset="" attribute that is generated by WordPress. See Issue #660. If you'd like to learn more about srcset="", see this article at WordPress.org.

  • Enhancement (Pro): Automatic Background Updates. It is now possible to enable automatic background updates that occur quietly in the background whenever new features, bug fixes, or security issues are addressed by our developers. See: Dashboard → Comet Cache Pro → Config. Options → Update Credentials. See also: Issue #827.

  • Enhancement (Pro): HTML Compressor + Accelerated Mobile Pages (AMP). Updated to the latest available release of the HTML Compressor (v161208) with improved support for Accelerated Mobile Pages. See: Issue #733. See also: HTML Compressor v161208 changelog.

  • Enhancement (Pro): HTML Compressor / AMP Compatibility. Improved compatibility with Accelerated Mobile Pages. There is a new HTML Compressor option that is enabled by default and it makes Comet Cache smart enough to auto-detect and selectively disable portions of the HTML Compressor that are incompatible with the AMP spec; i.e., routines that are not necessary when serving APMd pages. In short, if the URI being compressed ends with /amp/, or the document contains a top-level <html ⚡> tag (<html amp> is accepted as well), then features which are incompatible with Accelerated Mobile Pages will be disabled accordingly.

  • Compatibility: Avoid deprecated wp_get_sites() and use get_sites() instead. See Issue #848.

  • Documentation: Added Watered-Down Regex documentation notes to the inline documentation (in the software) about the use of ^ and $ in some places where these special characters are not fully supported. Also adding the same notes to the Watered-Down Regex KB Article. See also: Issue #611.

See also: Comet Cache v161214-RC Release Announcement

Reporting Issues / Feedback

Please report any issues or feedback related to this Release Candidate using this GitHub issue. Please post a comment below with details.

If you are reporting a UI-related issue, please include a screenshot.

If you are reporting a bug, please provide list of steps to reproduce and if the bug is related to an existing GitHub issue, please provide a link to that GitHub issue as well.


Reported Issues to Fix

None at this time.

@raamdev raamdev added the todo label Dec 14, 2016

@raamdev raamdev added this to the Next Release milestone Dec 14, 2016

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Dec 14, 2016

@jaswsinc TODO

  • Ensure the Mobile Mode browser.version token is updated to only contain the [major].[minor] version numbers.

Jason wrote in Slack:

Regarding mobile mode. Just an idea, but the current browser.version token is the full complete version (e.g., 1.2.12923923-alpha) and that's not very useful. In the future, or sometime between now and the official release, we should probably change browser.version so that it only contains the [major].[minor] version numbers. That way when this is used by others who need it, it's not just absolutely nuts to turn this on. Right now, it's fairly unreasonable to assume anyone could use that and actually make it work with any stability.

jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Dec 14, 2016

jaswsinc

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 14, 2016

@renzms

This comment has been minimized.

Copy link

renzms commented Dec 15, 2016

Confirmed Working

  • Documentation: Added Watered-Down Regex documentation notes to the inline documentation (in the software) about the use of ^ and $ in some places where these special characters are not fully supported. Also adding the same notes to the Watered-Down Regex KB Article. See also: Issue #611.

  • Enhancement: Widget Change Detection. Comet Cache can now detect when Appearance → Widgets are added/edited/removed, and Comet Cache will automatically clear the cache so that your site remains up-to-date. See Issue #411.

  • Enhancement (Pro): Automatic Background Updates. It is now possible to enable automatic background updates that occur quietly in the background whenever new features, bug fixes, or security issues are addressed by our developers. See: Dashboard → Comet Cache Pro → Config. Options → Update Credentials. See also: Issue #827.

  • Enhancement: Auto-Clearing Author Page Cache. This release makes Comet Cache smart enough to detect when a user is deleted (or removed from a child blog in a Network), at which time the Author page for that user will be cleared from the cache so it can be regenerated automatically. See Issue #304.

  • Enhancement: Multibyte Compatibility. This release improves support for WordPress Permalinks that contain UTF-8 symbols (or emojis) in them. More specifically, this release adds the /u flag to all preg_*() calls in cache clearing routines that generate cache paths from Watered-Down Regex patterns entered by a site owner. See: Issue #611.

  • Enhancement (Pro): Static CDN Filters and srcset. This release enhances Static CDN Filters in Comet Cache Pro. Static CDN Filters are now smart enough to filter all image sources included in an srcset="" attribute that is generated by WordPress. See Issue #660. If you'd like to learn more about srcset="", see this article at WordPress.org.

  • Compatibility: Avoid deprecated wp_get_sites() and use get_sites() instead. See Issue #848.

  • Enhancement (Pro): HTML Compressor + Accelerated Mobile Pages (AMP). Updated to the latest available release of the HTML Compressor (v161208) with improved support for Accelerated Mobile Pages. See: Issue #695 . See also: HTML Compressor v161208 changelog.

  • Enhancement (Pro): HTML Compressor / AMP Compatibility. Improved compatibility with Accelerated Mobile Pages. There is a new HTML Compressor option that is enabled by default and it makes Comet Cache smart enough to auto-detect and selectively disable portions of the HTML Compressor that are incompatible with the AMP spec; i.e., routines that are not necessary when serving APMd pages. In short, if the URI being compressed ends with /amp/, or the document contains a top-level <html ⚡> tag (<html amp> is accepted as well), then features which are incompatible with Accelerated Mobile Pages will be disabled accordingly.

  • Bug Fix: Improving OPcache detection. Now considering INI option opcache.restrict_api. Comet Cache is now smart enough to avoid the error: PHP Warning: Zend OPcache API is restricted by "restrict_api" configuration directive. See Issue #733.

  • New Feature (Pro): Mobile Mode. This release adds a new feature that is designed to improve compatibility with Adaptive themes for mobile devices. To learn more, please see: Dashboard → Comet Cache Pro → Plugin Options → Mobile-Adaptive Mode. See also: Issue #471 and the screenshots here.

@renzms

This comment has been minimized.

Copy link

renzms commented Dec 15, 2016

@raamdev

For the panels that use Watered Down REGEX and have external links, they correctly redirect and have the redirect links at http://cometcache.com/r/.

http://cometcache.com/r/watered-down-regex-syntax/ - https://cometcache.com/kb-article/watered-down-regex-syntax/

For the following, should we put them on a domain we own and redirect?

REQUEST_URI - https://gist.github.com/jaswsinc/338b6eb03a36c048c26f

HTTP_REFERER - http://php.net//manual/en/reserved.variables.server.php

HTTP_USER_AGENT - http://php.net//manual/en/reserved.variables.server.php

@KTS915

This comment has been minimized.

Copy link

KTS915 commented Dec 16, 2016

Using Firefox mobile on Android on my localhost test site running Linux Mint 17.3, I get the following message:

Array to string conversion in /var/www/html/blog/wp-content/plugins/comet-cache-pro/src/includes/traits/Shared/Conditional/Utils.php on line 156
@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Dec 17, 2016

@KTS915 Thanks for the report!

@jaswsinc Here's line 156 reported above:
https://github.com/websharks/comet-cache-pro/blob/161214-RC/src/includes/traits/Shared/ConditionalUtils.php#L156

Anything you're seeing there that might warrant holding up the release?

@KTS915

This comment has been minimized.

Copy link

KTS915 commented Dec 18, 2016

@raamdev @jaswsinc I am now getting this error message on Chrome as well. (Strangely, I wasn't getting it before.)

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Dec 18, 2016

Taking a look at this now.

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Dec 18, 2016

@KTS915 Thanks for reporting this.

Based on the iteration that error points to, I'd say the most likely cause of this is a rogue plugin. It's not possible to store an array in a cookie. Only a string or numeric value. So if the $_COOKIE superglobal contains a key holding an array, the only way I can see this happening is if another theme or plugin is forcing it to contain an array, at runtime.

@raamdev Having said that, we can add an is_string() check to this iteration instead of only typecasting it, just to avoid this error from occurring. I don't see this needing to hold up a release, but it's also a quick fix if you'd like to tweak it. In that iteration, if the value is not a string, we should just continue past it instead of trying to convert it.

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 18, 2016

raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Dec 18, 2016

@KTS915

This comment has been minimized.

Copy link

KTS915 commented Dec 18, 2016

@jaswsinc: Sadly, it doesn't appear to be a rogue plugin or custom theme. I've just tried both browsers on my Android phone on the same site, but with the 2015 theme and all plugins except CC deactivated. I also cleared the browser caches. I still get the same messages.

What seems strange to me is that this is not happening on my desktop PC with either browser.

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Dec 18, 2016

@KTS915 Have you tried clearing the browser cache on those mobile browsers, just in case the cookie(s) got corrupted somehow?

@KTS915

This comment has been minimized.

Copy link

KTS915 commented Dec 18, 2016

@raamdev : Yes, I did.

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Dec 21, 2016

Comet Cache v161221 has been released and includes changes from this GitHub Issue. See the v161221 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#858).

@raamdev raamdev closed this Dec 21, 2016

@wpsharks wpsharks locked and limited conversation to collaborators Dec 21, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.