Improve naming consistency of delivery options #206
Comments
|
Raam, there is a related bug, as follows: |
|
you can also see the mini text-size there. solution would be as described earlier: define it, to make sure. |
|
@RealDavidoff I'm not able to reproduce that bug. Where are you testing that? I just tried it on a regular comment form on my test site and changing to "no, do not subscribe" and then back to "yes, all comments/replies" had no effect on the delivery options box... it still works as expected. |
|
It's because you didn't start off at the SETTINGS page ;-) |
|
@RealDavidoff I'm still not able to reproduce any problem. With my Settings configured with "No, do not subscribe" as the default:
All of the options on the Comment Form work properly:
|
|
@raamdev Which do we prefer?
I'll vote for instantly, since it is a word that is more easily translated than the asap acronym. |
|
@kristineds This looks like an issue you could try to outline once Raam replies back. |
|
Yes, I agree that |
Next Actions
Once approved, repeat in the lite version of the software. Examples of a hard-coded delivery type status code that should NOT change.
Examples of a place where the word asap is used in HTML markup that is presented in a GUI.
|
|
@kristineds I outlined this for Renz. Maybe you can review his PR :-) |
Sure thing! I'll just wait for @renzms to submit it . :) |
|
@kristineds Ready for check! Thanks! |
|
@renzms Quoting what Jason said regarding POT translation files. :)
@jaswsinc: I'm seeing these files that needs to be updated as well, i.e. change
|
|
This shows instantly, even though the hard-coded DB value is This is just a code comment, and it references the hard-coded DB value. So you can leave this as-is. This shows instantly, even though the hard-coded DB value is Once this PR is merged, that translation utility should automatically convert The word @kristineds Have you run this branch through any tests inside WordPress? Were any of the issues you noted above causing problems from the UI perspective whenever you tested? |
|
@kristineds It might help if you ask Renz to take some screenshots to make reviewing a little easier. |
|
@kristineds This is still waiting for a review from you. See also the PR Renz submitted wpsharks/comment-mail-pro#50. @renzms Also, noting here that we'll need a PR for the Lite version as well. When a PR will be needed for both versions, it's best to always work on those side-by-side, i.e., to make the changes at the same time for both the Lite and the Pro version, otherwise it becomes easy to lose track of what changed where. |
|
@raamdev I reviewed it and @jaswsinc point out some changes that still need to be made. (wpsharks/comment-mail-pro#50 (comment)) I'm listing down the files that needs to be updated by Renz. @renzms Below are the list of the files that needs to be updated, i.e. change
|
Ok, will do. Just following the instructions in order of what @jaswsinc laid out earlier above:
Updating now and working on Lite version, thanks @kristineds |
|
@raamdev @jaswsinc There were 6 additional instances of
|
…ith instant on menu page descriptions; see: #206
@jaswsinc Is the only reason we're not changing all uses of It seems to me that changing all occurrences of |
That is correct, yes. |
|
Next Lite Release Changelog:
|
|
Next Pro Release Changelog:
|
|
Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#206). |
@RealDavidoff writes in #199 (comment)
The text was updated successfully, but these errors were encountered: