Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching Subscriptions by full email address should always return associated subscriptions #226

Closed
raamdev opened this issue Feb 9, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 9, 2016

When searching for Subscriptions that belong to a specific email address, it should be possible to paste in a full email address, hit search, and see the results filtered to only subscriptions that match that exact email address.

This is likely the most common type of search when searching subscriptions (i.e., searching by email address; such as when doing the administrative task of manually removing someone who asked to be unsubscribed).

At present, the behavior doesn't seem to work as expected. When I put in an email address, it seems to find more results than it should.

@raamdev raamdev added bug lite pro labels Feb 9, 2016
@raamdev raamdev modified the milestone: Next Release Feb 13, 2016
@raamdev raamdev modified the milestone: Next Release Mar 9, 2016
@IvanRF
Copy link

@IvanRF IvanRF commented May 23, 2016

I was about to post the same issue.

To add a bit more, if instead of "mail@domain.com" you search for "mail%40domain.com" it works 😄

@raamdev raamdev added this to the Future Release milestone May 24, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Jul 12, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Oct 11, 2016
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Nov 15, 2016

@jaswsinc You did a team video awhile back where you found the bug here and I just wanted to leave a comment with what you found: sub_email:test@example.com works, but test@example.com does not because full-text searches are being done IN BOOLEAN MODE, so the search results are more like Google rather than an exact match.

So we need to update the search algorithm so that it can detect when a full email address is being searched and then perform an exact match against the email table (i.e., how it's done when you search sub_email:test@example.com).

Here's a link to the video on Slack: https://websharks.slack.com/archives/comment-mail/p1479172353000208

@jaswrks
Copy link

@jaswrks jaswrks commented Nov 15, 2016

Ah, thank you for that.

@raamdev raamdev removed the needs estimate label Nov 29, 2016
jaswrks pushed a commit to wpsharks/comment-mail-pro that referenced this issue Dec 2, 2016
jaswsinc
…to the search to that specific email address and not result in any fuzzy or fulltext matching. See [Issue #226](wpsharks/comment-mail#226).
@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

Next Release Changelog:

  • Bug Fix: Searching by email address alone should always narrow to the search to that specific email address and not result in any fuzzy or fulltext matching. See Issue #226.
@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

Searching by email address is now treated exactly the same as if you had searched for: sub_email:test@example.com. You can now do this with just the email address: test@example.com

@renzms
Copy link
Contributor

@renzms renzms commented Dec 13, 2016

@jaswsinc @raamdev

Confirmed Working

screen shot 2016-12-13 at 3 15 41 pm

Tested using Comment Mail v161210-RC Pro + Lite and searched for specific email address. Searching by email address works for Subscriptions.

raamdev added a commit that referenced this issue Dec 13, 2016
- **Bug Fix:** Prevent browser autocomplete in Comment Mail options. See [Issue #319](#319).
- **Bug Fix:** Searching by email address alone should always narrow to the search to that specific email address and not result in any fuzzy or fulltext matching. See [Issue #226](#226).
- **Bug Fix:** The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See [Issue #315](#315).
- **Bug Fix:** Notify 'Subscribe to Comments Reloaded' users about the comment form template being disabled under certain scenarios. See [Issue #314](#314).
- **Bug Fix:** Do not attempt to import 'Subscribe to Comments Reloaded' (StCR) settings if StCR is no longer installed, even if old StCR options exist in the database. See [Issue #294](#294).
- **Bug Fix** (Pro): Do not show SparkPost partner image when Mandrill is selected as the RVE handler. See [Issue #318](#318).
- **Bug Fix** (Pro): Conflict checks between lite and pro corrected. This was not working properly in the previous release; i.e., installing Comment Mail Pro when Comment Mail Lite is already running should result in Comment Mail Lite being deactivated automatically. See [Issue #270](#270).
- **New Feature:** It is now possible to manually process the outgoing mail queue. See: **WP Dashboard → Comment Mail → Mail Queue**. See also [Issue #282](#282).
- **New Feature** (Pro): In Comment Mail Pro it is now possible to enable/disable comment content clipping entirely; e.g., if you prefer that email notifications include the full original comment content in raw HTML instead of being clipped and displayed in the email as plain text. See: **WP Dashboard → Comment Mail → Config. Options → Email Notification Clips**. See also: [Issue #281](#281).
- **Accessibility:** This release improves screen reader accessibility by adding `aria-hidden="true"` to all FontAwesome icons. See [Issue #304](#304).
- **Accessibility:** This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: **Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings**. See also [Issue #304](#304).
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 13, 2016

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#226).

@raamdev raamdev closed this Dec 13, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Dec 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.