RC :: Enhancement :: Pro Preview Link #227
Comments
|
I'm not sure when it happened, but it looks like this was done at some point recently:
However my feeling is that these two links should go after "Email Templates" and "Site Templates":
Also, while working on this we need to fix an issue with those menu links colliding with the bar below them when the browser is resized:
|
|
Related: #236 |
|
From #236, I think that solves the smaller browser issue of the links overlapping. I tested with a smaller browser size and with the notifications on top. The links stay in place, please see screen shot: Here is my test with it at regular browser size:
Is that okay, or should the |
|
Hmm, I'm also using Google Chrome on OS X:
In your screenshot it says Comment Mail Pro, or is that just because of the Phing Build version? Were there any recent merges after you tested and reviewed #236, that may have overwritten something in the CSS? |
The menu item says 'Pro' because we haven't finished updating the unified codebase to strip out all Pro-related things during a build (see #237). So I was testing the Lite build ( |
Nope, I will test with that version then. One question though, if I'm testing the Lite version of it, should I remove the logo? As that's a Pro feature, not sure ifs automatically disabled since the Pro-related features are still in the build. |
|
The logo doesn't show up in the Lite version. |
|
Next Release Changelog:
|
- **Restructured Codebase**: The codebase has been completely restructured to improve performance, enhance flexibility, and make it easier to build in new features! Props @jaswsinc. See [Issue #150](#150). - **Comment Mail Pro Upgrade Notice: Incompatible Advanced Templates.** This version of Comment Mail includes a rewritten and improved codebase. This rewrite, however, came with the unfortunate side effect of breaking backwards compatibility with Advanced Templates that were customized in a previous version of Comment Mail Pro. If you are currently using Comment Mail Pro and you've customized your Advanced Templates, all of your customized Advanced Templates will be backed up and the templates will then be reset to their new defaults. You will find the backup of your old customized template appended to the bottom of the new template, separated with a <code>Legacy Template Backup</code> PHP comment. See [example screenshots](#238 (comment)). Note: This change has no effect on Simple templates—only Advanced Templates are affected. Advanced Templates are a Pro-only feature, so this notice only applies to Comment Mail Pro. See [Issue #238](#238). - **Bug Fix**: Fixed a bug where `esc_html()` was being used where `esc_sql()` should've been used. Props @jaswsinc @kristineds. See [Issue #268](#268). - **Bug Fix**: Fixed a bug that in some scenarios resulted in a "DB table creation failure" error when activating the plugin. Props @thienhaxanh2405, @PanNovak, @kristineds, and @jaswsinc. See [Issue #260](#260). - **Bug Fix**: Fixed a bug where "New reply" notification emails were not being parsed properly by some Hotmail accounts and were showing up as blank. Props @kristineds. See [Issue #259](#259). - **Bug Fix**: Fixed a bug that allowed spam comments to create subscriptions in Comment Mail when using Akismet. Props @IvanRF. See [Issue #250](#250). - **Bug Fix** (Pro): When Chrome or Firefox Autofill Username/Password was enabled, the Comment Mail Pro Updater fields would incorrectly be autofilled by the browser with invalid credentials. This has been fixed. Props @renzms. [Issue #274](#274). - **Bug Fix**: Fixed a bug where the cron job for the Queue Processor could get deleted and never recreated, which would result in notifications getting stuck in the Mail Queue and not being sent out. If you ever installed Comment Mail and then deleted it (without first disabling Data Safeguards), and then installed Comment Mail again, you were probably affected by this issue. This release fixes the issue and makes the cron setup more robust. Props @kristineds, @renzms, @jaswsinc, and @IvanRF for help testing. See [Issue #194](#194) and [Issue #173](#173). - **Bug Fix:** Fixed a bug where a subscriber who selected Hourly Digest and who had never been notified before could, in some scenarios, have their subscription treated instead as a Weekly Digest. This bug was found and fixed during the codebase restructuring. Props @jaswsinc. See [Issue #150](#150) and additional discussion in [Issue #173](#173 (comment)). - **Bug Fix:** Fixed a bug where in some scenarios Mail Queue entries for Digest Notifications that should have been held for sending later were not being held and were also not being sent. They also would not have shown up in the Mail Queue Event Log. This bug was found and fixed during the codebase restructuring. Props @jaswsinc. See [Issue #150](#150) and additional discussion in [Issue #173](#173 (comment)). - **Enhancement**: Minor improvements to the Options Page menu links and positioning of the Pro Preview link. Props @renzms. See [Issue #227](#227). - **Enhancement**: It's now possible to use the following shortcodes in the Email Footer Tag for Email Footer Templates: `[home_url]`, `[blog_name_clip]`, and `[current_host_path]`. Props @kristineds and @IvanRF. See [Issue #246](#246). - **Enhancement**: Improved the Subscriptions meta box that appears on the Post Edit screen. For each subscription, the meta box now lists the full name and email address, the date the subscription was created, and a view link that allows you to view/edit the subscription. Props @kristineds. See [Issue #231](#231). - **UX Enhancement (Pro)**: Improved the Dashboard notice that appears when you try to enable the Pro version of Comment Mail when the Lite version is currently enabled. Props @kristineds @jaswsinc. See [Issue #230](#230). - **UX Enhancement**: When Subscribing Without Commenting, the Add New Subscription form now pre-populates the Name and Email address fields whenever possible. Props @kristineds. See [Issue #204](#204). - **UI Enhancement**: Dashboard notices generated by Comment Mail now use the WordPress-style dismiss button to keep things consistent. Props @kristineds. See [Issue #193](#193).
|
Comment Mail v160618 has been released and includes changes from this GitHub Issue. See the v160618 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#227). |
The RC is looking really great! Fantastic work, great improvements!
To take the recent navigation bar improvements to the next step, in the Lite version, I suggest moving the Pro Preview link into the main navigation area. Or, if that's not desirable try to find a way to make this easier to see. In this particular plugin (because it's a set-it-and forget-it kind of plugin), that Pro Preview link seems important. Ideally, it would be impossible to install the free version and not see there are pro features as soon as you begin to explore what it has to offer; i.e., one of the first things that you see.
The text was updated successfully, but these errors were encountered: