Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IP address in notification emails #288

Closed
raamdev opened this issue Jul 4, 2016 · 4 comments
Closed

Remove IP address in notification emails #288

raamdev opened this issue Jul 4, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jul 4, 2016

This was originally reported on the community forum.

We need an option to hide to remove the IP address that shows up in the notification emails to comply with data protection laws in certain countries, like Germany.

The subscriber IP address currently shows up in these templates:

@raamdev raamdev added the enhancement label Jul 4, 2016
@raamdev raamdev added this to the Next Release milestone Jul 4, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Jul 12, 2016
@kristineds kristineds self-assigned this Jul 25, 2016
@kristineds
Copy link
Contributor

@kristineds kristineds commented Jul 25, 2016

@raamdev Where exactly do you want this option to be added? Here's a sample mock that I came up with.

screen shot 2016-07-26 at 12 57 09 am

@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Jul 26, 2016

I was just reviewing the Comment Mail options panels and I realized that it would make more sense to just remove the IP address from the default templates altogether. That seems like a better idea than adding a new option for this.

@raamdev raamdev changed the title Option to hide IP address in notification emails Remove IP address in notification emails Jul 26, 2016
kristineds added a commit to wpsharks/comment-mail-pro that referenced this issue Jul 27, 2016
kristineds added a commit to wpsharks/comment-mail-pro that referenced this issue Jul 30, 2016
kristineds added a commit to wpsharks/comment-mail-pro that referenced this issue Aug 2, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Aug 2, 2016
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Aug 2, 2016

Next release changelog:

  • UX Enhancement: Removed IP address information from email notification templates to better comply with data protection laws in certain countries. Props @kristineds. See Issue #288.
@raamdev raamdev closed this Aug 2, 2016
raamdev added a commit that referenced this issue Aug 18, 2016
- **Bug Fix**: Fixed a bug where the "My Comment Subscriptions" link would appear on the Add New Subscription page (when Subscribing without Commenting) and would lead to a page that displayed an error message stating that there were no subscriptions to list. That link is now hidden when there are no subscriptions to list. Props @Reedyseth @kristineds. See [Issue #229](#229).
- **Bug Fix** (Pro): Removed an erroneous anchor tag in the Advanced Template for Comment Notification Message Body. Props @kristineds. See [Issue #287](#287).
- **UI Enhancement:** Improved the nav bar at the top of the options pages to reduce unnecessary whitespace. Also moved the Restore button to the nav bar so that it's not so prominent. Props @renzms. See [Issue #284](#284).
- **UI Enhancement:** Added links to the Comment Mail [Twitter](http://twitter.com/CommentMail) and [Facebook](https://www.facebook.com/Comment-Mail-565683256946855/) pages to the nav bar on the options page. Props @renzms. See [Issue #286](#286).
- **UX Enhancement:** Removed IP address information from email notification templates to better comply with data protection laws in certain countries. Props @kristineds. See [Issue #288](#288).
- **SEO Improvement:** Added `rel="nofollow"` to the "Subscribe without Commenting" link and "Manage Subscriptions" link on the comment subscription form to avoid indexing or transferring PageRank. Props @IvanRF. See [Issue #80](wpsharks/comment-mail-pro#80).
- Removed several development-only files from the distributable that were inadvertently included during the build process. See [Issue #285](#285).
- Added Renz Sevilla (`renzms`) to the contributors list.
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Aug 18, 2016

Comment Mail v160818 has been released and includes changes from this GitHub Issue. See the v160818 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#288).

@wpsharks wpsharks locked and limited conversation to collaborators Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.