Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accessibility for Screen Readers #304

Closed
renzms opened this issue Oct 24, 2016 · 13 comments
Closed

Improve Accessibility for Screen Readers #304

renzms opened this issue Oct 24, 2016 · 13 comments
Assignees
Milestone

Comments

@renzms
Copy link
Contributor

@renzms renzms commented Oct 24, 2016

On the Manage Subscriptions or Subscribe page, there are drop downs. When selecting a post, and selecting a comment to subscribe to, a screen reader will read this as read only and goes into edit mode when it should remain in browse mode.

It would be nice if instead, we replace these drop downs with Combo Boxes or drop downs with aria-labels to let the user know when it is expanded or collapsed.


Referencing Internal Ticket:

https://websharks.zendesk.com/agent/tickets/14702

@alexstine
Copy link

@alexstine alexstine commented Oct 24, 2016

+1. Really looking for a solution, I am willing to test and work with everyone to get this fixed.

Thanks.

@raamdev raamdev added this to the Future Release milestone Oct 29, 2016
@raamdev raamdev changed the title Feature Request: Improve User Accessibility for users who use Screen Readers Manage Subscriptions and Add Subscription page are not Screen Reader-friendly Oct 29, 2016
@alexstine
Copy link

@alexstine alexstine commented Oct 30, 2016

@raamdev, This is more general, but the plugin has lots of FontAwesome icons scattered about through various parts of the plugin. Think in the future
aria-hidden="true"
could be added so screen readers know to ignore them? Haven't tried, but maybe that would help us on the drop downs by telling the screen reader to ignore the "read only" part, maybe that is a temporary solution.

@raamdev raamdev changed the title Manage Subscriptions and Add Subscription page are not Screen Reader-friendly Improve Accessibility for Screen Readers Oct 31, 2016
@raamdev raamdev removed the needs estimate label Nov 29, 2016
@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

New option coming soon...

See: Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings

2016-12-01_23-47-12

@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

jaswrks pushed a commit to wpsharks/comment-mail-pro that referenced this issue Dec 2, 2016
jaswsinc
@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

Next Release Changelog:

  • Accessibility: This release improves screen reader accessibility by adding aria-hidden="true" to all FontAwesome icons. See Issue #304.

  • Accessibility: This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings. See also Issue #304.

@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

Referencing accessibility issues with the jQuery Chosen extension that powers our enhanced select option menus in Comment Mail. Disabling jQuery Chosen (i.e., select menu option enhancements in Comment Mail) will restore accessibility until such time as this jQuery extension is enhanced. See: harvesthq/chosen#264

@alexstine
Copy link

@alexstine alexstine commented Dec 2, 2016

@jaswsinc, is this option available yet? To disable the special jQuery drop downs? Would really like to see some push to get this out fast since there are laws that say sites should be accessible.

If it's not an option, are there any quick patch work around?

Thanks.

@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

@tech55541 This is going to get pushed out really soon, yes.

In the meantime, if you'd like to test it even earlier you can signup for our beta mailing list here: http://comment-mail.com/beta-testers/ and you'll get an early copy of the release candidate via email.

jaswrks referenced this issue in wpsharks/comment-mail-pro Dec 2, 2016
@jaswrks
Copy link

@jaswrks jaswrks commented Dec 2, 2016

@tech55541 Here is an even earlier copy that is available for testing. This is an unstable bleeding edge copy of the latest revisions that make this possible. Please report any problems. Thanks!

Download link: https://cdn.wpsharks.com/software/bleeding-edge/comment-mail-pro/10bafd51ac92c9e.zip

@alexstine
Copy link

@alexstine alexstine commented Dec 2, 2016

Will test on my staging site and let you know @jaswsinc.

@alexstine
Copy link

@alexstine alexstine commented Dec 2, 2016

Hello again @jaswsinc,

I really haven't tested functionality overall yet, but the accessibility fix works. Please do include this in the documentation or make the accessibility option default. This jQuery drop downs in my opinion should not be enabled by default, it would not do the blind community any favors if the person setting this plugin up overlooks this setting.

I understand we're in the early stages, thanks for taking such swift action here. :)

@renzms
Copy link
Contributor Author

@renzms renzms commented Dec 9, 2016

@jaswsinc @raamdev

Confirmed as working in latest bleeding edge version of Comment Mail Pro

Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings → Select Menu Options: Enhance? → No

screen shot 2016-12-09 at 7 20 13 pm

screen shot 2016-12-09 at 7 08 12 pm
screen shot 2016-12-09 at 7 07 33 pm

The dropdown selectors are not enhanced by jQuery and allow for better accessibility for readers.


Default View with jQuery enhancements

Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings → Select Menu Options: Enhance? → Yes
screen shot 2016-12-09 at 7 19 09 pm
screen shot 2016-12-09 at 7 18 48 pm

raamdev added a commit that referenced this issue Dec 13, 2016
- **Bug Fix:** Prevent browser autocomplete in Comment Mail options. See [Issue #319](#319).
- **Bug Fix:** Searching by email address alone should always narrow to the search to that specific email address and not result in any fuzzy or fulltext matching. See [Issue #226](#226).
- **Bug Fix:** The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See [Issue #315](#315).
- **Bug Fix:** Notify 'Subscribe to Comments Reloaded' users about the comment form template being disabled under certain scenarios. See [Issue #314](#314).
- **Bug Fix:** Do not attempt to import 'Subscribe to Comments Reloaded' (StCR) settings if StCR is no longer installed, even if old StCR options exist in the database. See [Issue #294](#294).
- **Bug Fix** (Pro): Do not show SparkPost partner image when Mandrill is selected as the RVE handler. See [Issue #318](#318).
- **Bug Fix** (Pro): Conflict checks between lite and pro corrected. This was not working properly in the previous release; i.e., installing Comment Mail Pro when Comment Mail Lite is already running should result in Comment Mail Lite being deactivated automatically. See [Issue #270](#270).
- **New Feature:** It is now possible to manually process the outgoing mail queue. See: **WP Dashboard → Comment Mail → Mail Queue**. See also [Issue #282](#282).
- **New Feature** (Pro): In Comment Mail Pro it is now possible to enable/disable comment content clipping entirely; e.g., if you prefer that email notifications include the full original comment content in raw HTML instead of being clipped and displayed in the email as plain text. See: **WP Dashboard → Comment Mail → Config. Options → Email Notification Clips**. See also: [Issue #281](#281).
- **Accessibility:** This release improves screen reader accessibility by adding `aria-hidden="true"` to all FontAwesome icons. See [Issue #304](#304).
- **Accessibility:** This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: **Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings**. See also [Issue #304](#304).
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 13, 2016

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#304).

@raamdev raamdev closed this Dec 13, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Dec 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.