-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Proper Case for Statuses and Events on UI #72
Comments
Adding a project outline above. See: https://quire.io/w/7C4cVjc0O3g2ZXK3OnQUG9eJ/Modify_i18n_Utilitie... |
@kristineds You're welcome to give this one a shot if you'd like. It was outlined on Quire a while back and it's one that might be good practice. If you decide to tackle it just let me know and I can help if you need it. |
@jaswsinc I'm ready to work on this. Should I start with creating a feature branch for this issue and work on the "Modify i18n Utilities Class" step? |
@jaswsinc Submitting PR for CM Lite and Pro to Modify i18n Utilities Class |
Modify i18n Utilities Class; See wpsharks/comment-mail#72
Modify i18n Utilities Class; See #72
Perfect, yes. I merged your PRs for step one. Nice! |
@jaswsinc Cool! Could you please you give me some guidance on what to do on the next step ~ Update Codebase; i.e., Utility Calls (Run a search on the entire codebase for calls to those i18n utilities)? Thanks |
What you want to search for is Note also, that in this file, there are still several other utilities that need to be converted in much the same way that you did with These are the methods that still need work:
Once each of these are converted, you will need to search the codebase to find areas where each of these have been used also, and update accordingly; e.g., |
@jaswsinc: Can you check this code when you get the chance before I send the PR for it? :) Thanks! https://gist.github.com/kristineds/72f15c4833dc102cb0f6 |
@jaswsinc Submitting PRs for CM Lite and Pro to Update codebase for i18n utility calls: |
Update codebase for i18n utility calls; See wpsharks/comment-mail#72
Update codebase for i18n utility calls; See #72
@kristineds Merged both of those. Thank you! Next Actions (Final Step)
|
@jaswsinc Submitting PRs for CM Lite and Pro for Step 3 |
Update codebase for i18n utility calls; See: wpsharks/comment-mail#72
Update codebase for i18n utility calls; See: #72
@kristineds Merged both. Nice work! 💯 |
Next Lite Release Changelog:
|
Next Pro Release Changelog:
|
Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#72). |
While it's fine to use all lowercase for the statuses and events in the database (e.g.,
subscribed
,unsubscribed
,trashed
,inserted
, etc.) it would be nice to use proper case (Subscribed
,Unsubscribed
,Trashed
,Inserted
, etc.) on the front-end UI.It feels a bit out of place to see everything else in the Subscriptions table and the Event Log using proper case except for the statuses and events:
Next Actions / Project Outline
See: https://quire.io/w/7C4cVjc0O3g2ZXK3OnQUG9eJ/Modify_i18n_Utilitie...
The text was updated successfully, but these errors were encountered: