Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Corruption #87

Closed
jaswrks opened this issue Jun 4, 2015 · 11 comments
Closed

Icon Corruption #87

jaswrks opened this issue Jun 4, 2015 · 11 comments
Labels
bug
Milestone

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Jun 4, 2015

One of the CM icons got corrupted in a recent update.

2015-06-03_21-53-03

@jaswrks jaswrks added the bug label Jun 4, 2015
@jaswrks jaswrks added this to the Initial Public Release milestone Jun 4, 2015
@jaswrks jaswrks closed this Jun 4, 2015
@Reedyseth
Copy link
Contributor

@Reedyseth Reedyseth commented Dec 21, 2015

I would like to reopen this issue since in the latest update of Comment Mail Pro I see a wrong Icon on the CM panels, at least this is my perception.

image

As you can see on the image there is a broom instead of the CM envelop Icon, perhaps there is a conversation that I missed regarding this matter, can you confirm the issue.

Using the version wpsharks/comment-mail-pro@139012a

@raamdev raamdev reopened this Dec 22, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 22, 2015

@Reedyseth Thank you for the report. I've actually seen that too (namely in the icon that shows up in each subscriber row) and I thought it was just a browser caching glitch. That may still be what it is (possibly related to our testing various versions of the plugin), but we should investigate more closely to make sure this isn't a bug.

@raamdev raamdev modified the milestones: Next Release, v150626 Dec 22, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 22, 2015

The broom icon is used by ZenCache and should not appear in Comment Mail.

@Reedyseth
Copy link
Contributor

@Reedyseth Reedyseth commented Dec 22, 2015

Thank you for taking a look at the report !

@Reedyseth
Copy link
Contributor

@Reedyseth Reedyseth commented Dec 22, 2015

I just digg a bit and found that the Icon assigment by Comment Mail is correct, this is using the code on the CSS Style:

content: '\e000'

Also ZenCache uses the same reference to the Icon, so having both plugins installed is causing that ZenCache overwrites the Comment Mail icon.

Changing the reference to the Icon seems to fix the issue, but I think this will break the plugin standars

content: '\e001'

If there is not issue with this I could do more tests and then submit my pull request.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 22, 2015

@Reedyseth Nice catch!! Yes, I've confirmed that is the bug here: If you install the latest version of ZenCache Pro + Comment Mail Pro, the icon that shows up in Comment Mail is incorrect (the broom).

It looks like the problem is that the Comment Mail v151221-RC is using an older version of the Sharkicons package.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 23, 2015

@Reedyseth This has been fixed in #188 and wpsharks/comment-mail-pro#42.

@raamdev raamdev closed this Dec 23, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 23, 2015

Next Lite Release Changelog:

  • Bug Fix: Fixed a bug where certain icons would not appear, or the wrong icon would appear, when Comment Mail was installed alongside the ZenCache plugin. Both plugins use the same Sharkicons library, but were using different versions, which introduced a conflict. Comment Mail has been updated to use the latest version of the Sharkicons library. Props @Reedyseth. See Issue #87.
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 23, 2015

Next Pro Release Changelog:

  • Bug Fix: Fixed a bug where certain icons would not appear, or the wrong icon would appear, when Comment Mail was installed alongside the ZenCache plugin. Both plugins use the same Sharkicons library, but were using different versions, which introduced a conflict. Comment Mail has been updated to use the latest version of the Sharkicons library. Props @Reedyseth. See Issue #87.
@wpsharks wpsharks locked and limited conversation to collaborators Dec 24, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#87).

@Reedyseth
Copy link
Contributor

@Reedyseth Reedyseth commented Dec 27, 2015

This has been fixed in #188 and wpsharks/comment-mail-pro#42.

Awesome, you spot the issue very fast, thank you for the update :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.