Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks CSS on IE? #16

Closed
jaswrks opened this issue May 15, 2014 · 15 comments
Closed

Breaks CSS on IE? #16

jaswrks opened this issue May 15, 2014 · 15 comments
Labels

Comments

@jaswrks
Copy link

jaswrks commented May 15, 2014

wpsharks/comet-cache#163

@jaswrks jaswrks added the bug label May 15, 2014
@jaswrks
Copy link
Author

jaswrks commented May 15, 2014

@BruceCaldwell and I were able to reproduce this in IE v10. It seems to related to an incompatibility with @media queries. Investigating further to identify the exact underlying cause of this.

@raamdev
Copy link
Contributor

raamdev commented May 15, 2014

Any idea what the ETA might be on a fix for this? I'm trying to figure out if I should hold back the next release of Quick Cache until this makes it in. I know the HTML Compressor feature is marked as "experimental" in Quick Cache, but it would still be nice to get this fix in if possible. If you don't see a fix happening before the weekend, I'll move forward without it and get it into the following release.

@jaswrks
Copy link
Author

jaswrks commented May 15, 2014

I'll try to update you shortly. I got sidetracked for a moment, but I intend to look closer at this shortly to find out what the issue actually is. If I can determine that today, I can give you a timeframe.

@jaswrks
Copy link
Author

jaswrks commented May 16, 2014

We confirmed the issue is related to the nesting of @media queries. Not all browsers offer good support for this, notably IE 9 and 10. It's going to take some time to investigate this further and come up with a good solution. I'd suggest pulling it from the next release. I suspect this could take at least a couple of days to get corrected.

http://jsfiddle.net/JasWSInc/QLzRP/

@jaswrks
Copy link
Author

jaswrks commented May 16, 2014

@raamdev
Copy link
Contributor

raamdev commented May 16, 2014

I'd suggest pulling it from the next release. I suspect this could take at least a couple of days to get corrected.

Pulling it seems like a lot of work at this point as there's a lot of code related to that feature already integrated into Quick Cache Pro. As much as I don't want to, it probably makes more sense to just delay the beta.

@jaswrks
Copy link
Author

jaswrks commented May 16, 2014

OK. Well that sounds like a plan too. I will try to get this fixed up quickly.

@raamdev
Copy link
Contributor

raamdev commented May 16, 2014

@JasWSInc Thanks! As an interim solution, you might also just add an option to disable embedded @media queries and then I can have that disabled by default and add a warning about that specific option not playing well with IE.

@jaswrks
Copy link
Author

jaswrks commented May 19, 2014

@raamdev I'm close to having this resolved. Might be later this evening or tomorrow once I've completed some additional tweaks and run my initial tests.

@raamdev
Copy link
Contributor

raamdev commented May 19, 2014

@JasWSInc Awesome! I'd like to release a beta tonight, let people test it for the next week, and plan to do an official release next Monday. Would you prefer that I hide/disable this feature to give us a lot more time for testing (i.e., a future release) or would you feel comfortable with it getting tested in a 1 week beta?

It's your call. I'll go with whatever you feel comfortable with. :)

@jaswrks
Copy link
Author

jaswrks commented May 19, 2014

getting tested in a 1 week beta?

Yep, that would be great! Thanks :-) I'd be fine with having it tested. Never know what else might turn up that we all might have missed, so any feedback would be great. This bug impacts MSIE 9, 10, 11 and iOS Safari. The more recent versions of Chrome, Firefox, Safari, Opera do just fine. So while it's a very important issue to get resolved, I don't think it's so bad that we can't get some feedback from what we have at this point. That is, if you're OK with it of course.

Also, feel free to direct them here to this repo to submit bugs if you prefer.

@raamdev
Copy link
Contributor

raamdev commented May 19, 2014

Also, feel free to direct them here to this repo to submit bugs if you prefer.

Will do!

Also, if after a week of testing in beta we decide the HTML Compressor needs more bugs ironed out, I can always flip the switch on that feature and hide its options panel before doing the official release. That's always an option, if necessary.

jaswrks pushed a commit that referenced this issue May 19, 2014
jaswrks pushed a commit that referenced this issue May 19, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
jaswrks pushed a commit that referenced this issue May 20, 2014
Working to resolve #16, #13, #17, #15
@jaswrks
Copy link
Author

jaswrks commented May 20, 2014

@raamdev This was resolved in v140520.
https://github.com/WebSharks/HTML-Compressor/releases

@raamdev
Copy link
Contributor

raamdev commented May 20, 2014

@JasWSInc Awesome! Thanks so much! :) I've updated the 000000-dev branch of Quick Cache Pro with the latest release of HTML Compressor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants