Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Checks (Bug In Scheme Detection) #61

Closed
jaswrks opened this issue Jul 15, 2015 · 6 comments
Closed

SSL Checks (Bug In Scheme Detection) #61

jaswrks opened this issue Jul 15, 2015 · 6 comments
Labels
bug
Milestone

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Jul 15, 2015

We should probably update this line of code to force a specific data type. At present, this is assuming SERVER_PORT will be a string, but if a server is setting the value to an integer it might be causing some trouble. https://github.com/websharks/html-compressor/blob/150512/src/includes/classes/Core.php#L2861

A similar issue here. This could also look for a boolean-ish true value.
https://github.com/websharks/html-compressor/blob/150512/src/includes/classes/Core.php#L2866
e.g., if(filter_var($_SERVER['HTTPS'], FILTER_VALIDATE_BOOLEAN))

@jaswrks jaswrks added the bug label Jul 15, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Jul 15, 2015

Referencing internal ticket that led to this issue: https://websharks.zendesk.com/agent/tickets/7319

jaswrks pushed a commit that referenced this issue Jul 16, 2015
@jaswrks
Copy link
Author

@jaswrks jaswrks commented Jul 16, 2015

Done. Coming in the next release.

@jaswrks jaswrks closed this Jul 16, 2015
jaswrks pushed a commit that referenced this issue Jul 16, 2015
Improving SSL detection. See: #61
@raamdev
Copy link
Contributor

@raamdev raamdev commented Jul 17, 2015

Woohoo!

@raamdev
Copy link
Contributor

@raamdev raamdev commented Aug 18, 2015

@jaswsinc I noticed there was no changelog entry for this issue here: https://github.com/websharks/html-compressor/releases

@raamdev raamdev reopened this Aug 18, 2015
@raamdev raamdev added this to the Next Release milestone Aug 18, 2015
@jaswrks
Copy link
Author

@jaswrks jaswrks commented Aug 19, 2015

Next Release Changelog:

  • Bug Fix: Improved strict data type comparison when analyzing $_SERVER environment variables to detect an https:// connection URL. We now detect (integer)443 and (string)443. In addition, we can now pick up $_SERVER['HTTPS'] being any of 1|on|yes|true (caSe insensitive).
@jaswrks jaswrks closed this Aug 19, 2015
@raamdev
Copy link
Contributor

@raamdev raamdev commented Aug 21, 2015

ZenCache Pro v150821 has been released and includes changes from this GitHub Issue.

See the ZenCache Pro v150821 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#61).

@wpsharks wpsharks locked and limited conversation to collaborators Aug 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.