Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST_SCHEME http Over SSL? #73

Closed
jaswrks opened this issue Sep 23, 2015 · 6 comments
Closed

REQUEST_SCHEME http Over SSL? #73

jaswrks opened this issue Sep 23, 2015 · 6 comments

Comments

@jaswrks
Copy link

@jaswrks jaswrks commented Sep 23, 2015

I have at least one report of $_SERVER['REQUEST_SCHEME'] being set to http on GoDaddy servers whenever the current request is actually over https and $_SERVER['HTTPS'] === 'on'. This creates a problem in the HTML Compressor as reported here internally: https://websharks.zendesk.com/agent/tickets/8461

cc @raamdev

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 23, 2015

Next Actions

  • Comment these lines so that we are detecting SSL only. The REQUEST_SCHEME is not absolutely necessary there, and since we now know it is unreliable on some shared hosts, we can just comment this block out.

Loading

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 23, 2015

@jaswsinc Can you confirm if wpsharks/comet-cache#413 and wpsharks/comet-cache#348 both look related to this issue?

Loading

@jaswrks jaswrks closed this Sep 23, 2015
@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 23, 2015

@raamdev Hard to say for sure, but definitely sounds like the same sort of thing.

Loading

@raamdev
Copy link
Contributor

@raamdev raamdev commented Sep 23, 2015

@jaswsinc In both of those issues, the user had "just switched from http to https" on their entire site, which sounds to me like it could have exposed this bug. wpsharks/comet-cache#413 talks about CDN, but that could have been a coincidence.

Loading

@jaswrks
Copy link
Author

@jaswrks jaswrks commented Sep 24, 2015

I agree. It sounds like this could have been the underlying cause.

Loading

@raamdev
Copy link
Contributor

@raamdev raamdev commented Oct 2, 2015

ZenCache Pro v151002 has been released and includes changes from this GitHub Issue.

See the ZenCache Pro v151002 release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#73).

Loading

@wpsharks wpsharks locked and limited conversation to collaborators Oct 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants