New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2Member v161117-RC (Release Candidate) #1019

Closed
raamdev opened this Issue Nov 19, 2016 · 13 comments

Comments

Projects
None yet
4 participants
@raamdev
Copy link
Contributor

raamdev commented Nov 19, 2016

Target Date for General Availability Release: November 23rd 29th, 2016

Downloads

Changelog

Reporting Issues / Feedback

Please report any issues or feedback related to this Release Candidate using this GitHub issue. Please post a comment below with details.

If you are reporting a UI-related issue, please include a screenshot.

If you are reporting a bug, please provide list of steps to reproduce and if the bug is related to an existing GitHub issue, please provide a link to that GitHub issue as well.


Reported Issues to Fix

None at this time.

@raamdev raamdev added the todo label Nov 19, 2016

@raamdev raamdev added this to the Next Release milestone Nov 19, 2016

@renzms

This comment has been minimized.

Copy link
Contributor

renzms commented Nov 21, 2016

Confirmed as Working

  • (s2Member/s2Member Pro) Bug Fix: Username/password email being sent to users whenever Custom Passwords are enabled in your s2Member configuration and registration occurs via the default wp-login.php?action=register form. Fixed in this release.

  • (s2Member/s2Member Pro) SSL Compatibility & Option Deprecation: In previous versions of s2Member there was a setting in the UI that allowed you to force non-SSL redirects to the Login Welcome Page. By popular demand, this setting has been deprecated and removed from the UI.

  • (s2Member/s2Member Pro) Phing Build Routines: Starting with this release, developers working on the s2Member project are now able to perform builds of the software via the websharks/phings project; i.e., the structure of the plugin directories has been changed (slightly) to conform to Phing and PSR4 standards. This makes it easier for our developers to prepare and release new versions of the software in the future.

  • (s2Member/s2Member Pro) IP Detection: This release improves s2Member's ability to determine the current user's IP address. s2Member now searches through HTTP_CF_CONNECTING_IP, HTTP_CLIENT_IP, HTTP_X_FORWARDED_FOR, HTTP_X_FORWARDED, HTTP_X_CLUSTER_CLIENT_IP, HTTP_FORWARDED_FOR, HTTP_FORWARDED, HTTP_VIA, and REMOTE_ADDR (in that order) to locate the first valid public IP address. Either IPv4 or IPv6. Among other things, this improves s2Member's compatibility with sites using CloudFlare.

  • (s2Member Pro) JSON API: In the pro version it is now possible to use the s2Member Pro Remote Operations API to send and receive JSON input/output. This makes the Remote Operations API in s2Member compatible with a variety of scripting languages, not just PHP; i.e., prior to this release the Remote Operations API required that you always use PHP's serialize() and unserialize() functions when making API calls. The use of serialize() and unserialize() are no longer a requirement since input/output data is now sent and received in the more portable JSON format. For new code samples, please see: WordPress Dashboard → s2Member → API / Scripting → Pro API For Remote Operations.

  • (s2Member Pro) Bug Fix: Stripe refund notifications via the Stripe Webhook were always interpreted by s2Member as full refunds. This release corrects this bug so that s2Member will handle partial refunds via the Stripe API properly in all cases.

  • (s2Member/s2Member Pro) Bug Fix: Updating profile via [s2Member-Profile /] when changing email addresses may leave the old email address on configured email list servers in some scenarios.

@renzms

This comment has been minimized.

Copy link
Contributor

renzms commented Nov 22, 2016

@jaswsinc / @raamdev

Tested

(s2Member Pro) Bug Fix: Stripe refund notifications via the Stripe Webhook were always interpreted by s2Member as full refunds. This release corrects this bug so that s2Member will handle partial refunds via the Stripe API properly in all cases.

Observation

I believe this to be working, but please correct me if I'm wrong if this isn't the way partial refunds are supposed to be detected.

The Stripe Webhook/IPN event type identified as: charge.refunded is only noted when a full refund is issued, and partial refunds are ignored by s2Member.

When testing partial refunds for Stripe in the stripe-ipn.log: the following is noted for partial refunds

 [s2member_log] => Array
        (
            [0] => Ignoring this Webhook/IPN. The event does NOT require any action on the part of s2Member.
        )

After submitting multiple partial refunds till the amount equated to the full refund amount this is noted in the logs:

 [s2member_log] => Array
        (
            [0] => Stripe Webhook/IPN event type identified as: `charge.refunded` on: Tue Nov 22, 2016 6:21:08 am UTC
            [1] => Webhook/IPN event `charge.refunded` reformulated. Piping through s2Member's core gateway processor.
            [2] => Please check core IPN logs for further processing details.
        )

When full refund was issued, this is noted in the logs:

   [s2member_log] => Array
        (
            [0] => Stripe Webhook/IPN event type identified as: `charge.refunded` on: Tue Nov 22, 2016 6:35:12 am UTC
            [1] => Webhook/IPN event `charge.refunded` reformulated. Piping through s2Member's core gateway processor.
            [2] => Please check core IPN logs for further processing details.
        )

)
@jaswrks

This comment has been minimized.

Copy link
Contributor

jaswrks commented Nov 22, 2016

@renzms Thank you. Can you post a full copy of that log file for me please? Maybe upload it to a service like CloudUp.com.

@renzms

This comment has been minimized.

Copy link
Contributor

renzms commented Nov 22, 2016

@jaswsinc Sure thing: https://cloudup.com/cHK9zupCFVM password shared via slack

@jaswrks

This comment has been minimized.

Copy link
Contributor

jaswrks commented Nov 22, 2016

@renzms Were you running any other plugins besides s2Member when you ran this test? I'm curious because the logs that you sent me show behavior that I can't seem to reproduce.

If you can clear all of your existing log files, then run another test against just a partial refund for me I'd appreciate it. I'd love to see another set of log files and the Pro-Form shortcode that you used to reproduce the partial refund behavior that you observed. Thanks! :-)

@renzms

This comment has been minimized.

Copy link
Contributor

renzms commented Nov 23, 2016

@jaswsinc Hi Jason, no other plugins besides s2Member Framework + Pro Add on.

Cleared all the logs and tested another partial refund, new logs here - https://cloudup.com/csvGMC6QJJC. Same password as previous share link. 👍

Pro-From shortcode:

[s2Member-Pro-Stripe-Form level="2" ccaps="" desc="$40 USD / Monthly (recurring charge, for ongoing access)" cc="USD" custom="name.domain.net" ta="0" tp="0" tt="D" ra="40" rp="1" rt="M" rr="1" coupon="" accept_coupons="0" default_country_code="US" captcha="0" /]
@jaswrks

This comment has been minimized.

Copy link
Contributor

jaswrks commented Nov 23, 2016

Copy that. Thank you. That log looks good and as expected.

@renzms

This comment has been minimized.

Copy link
Contributor

renzms commented Nov 26, 2016

@raamdev

All issues confirmed, but I'd like to play around with other settings to check for any visual and UI errors.

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Nov 26, 2016

@renzms Great! Thank you. I forgot to leave a comment here, but the GA release date has been pushed from November 23rd to November 29th, so you have a few more days for testing. :-)

@GillianTrethewey

This comment has been minimized.

Copy link

GillianTrethewey commented Nov 26, 2016

@raamdev

Hello! Just thought I would chime in and let you know I had an issue with a client with a secure site where her members weren't being recognized and were being re-directed to the Join Now page.

  • I thought at first it was a plugin conflict with WooCommerce as the client had just installed it and the timing was coincident. (She knows enough to be dangerous and likes to play with plugins - I'm working on that with her!)

  • after reaching out, @Jaswsinc let me know about your new Woo S2 extension product - and about changing the Login Page Settings to NO don't redirect. I did the latter rather than introducing another variable in the mix at that time.

  • It looked like it worked at first and then some members were still having issues.

  • I read your Blog entry about the Beta release RC, so I installed both the S2 and PRO via FTP, cleared the cache, and all seems just fine now. Tested with various levels of members.

Now on my own membership site, which just has S2 (Pro is coming - shoemaker's children syndrome), I only had to fix the setting to NO and it was fine. But today I installed the RC version anyway.

(I had noticed prior to making these fixes on my site that more members than usual were locking themselves out, which was fixed by having them clear their history and cache, turning off their computer, making sure their Chrome browser was up to date and so on. I also told them not to autofill just in case.)

I hope that clears everything up and will let you know if not. Thanks!

@GillianTrethewey

This comment has been minimized.

Copy link

GillianTrethewey commented Nov 28, 2016

@raamdev @jaswsinc Don't know if this will help, but the issue above ended up being solved by turning ON: "Redirects all requests made to your site over HTTPS."

Thanks!

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Nov 29, 2016

@GillianTrethewey Thank you very much for the testing and the feedback! :-)

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Nov 29, 2016

s2Member v161129 has been released and includes changes from this GitHub Issue. See the v161129 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1019).

@raamdev raamdev closed this Nov 29, 2016

@wpsharks wpsharks locked and limited conversation to collaborators Nov 29, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.