Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Missing Changelog in Plugin Reactivation Notice #1027

Closed
jaswrks opened this issue Dec 2, 2016 · 17 comments
Closed

Bug: Missing Changelog in Plugin Reactivation Notice #1027

jaswrks opened this issue Dec 2, 2016 · 17 comments
Assignees
Labels
bug
Milestone

Comments

@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Dec 2, 2016

A customer writes...

Where is the most current version "change log"? after updating I clicked on the link which opened a blank page.


The location of the changelog may have changed in the last release and the link in the s2Member reactivation notice may have broken. Needs research.

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Dec 2, 2016

@raamdev raamdev added this to the Future Release milestone Dec 5, 2016
@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 5, 2016

@raamdev
Copy link
Contributor

@raamdev raamdev commented Dec 6, 2016

2016-12-06_17-07-26

Here's what the changelog link links to in the above screenshot:
https://example.com/wordpress/wp-admin/plugins.php

jaswrks referenced this issue Jan 5, 2017
jaswsinc
@jaswrks jaswrks modified the milestones: Next Release, Future Release Jan 5, 2017
@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Jan 5, 2017

This has been resolved in the dev branch.

@jaswrks jaswrks closed this Jan 5, 2017
@jaswrks jaswrks reopened this Jan 5, 2017
@jaswrks jaswrks removed the needs research label Jan 5, 2017
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
…to s2member.com locations. See: wpsharks/s2member#1027 and wpsharks/s2member#668
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
…to s2member.com locations. See: wpsharks/s2member#1027 and wpsharks/s2member#668
@renzms
Copy link
Contributor

@renzms renzms commented Jan 27, 2017

@jaswsinc @raamdev

Testing all links and going through them systematically. So far so good.

Only one thing to note so far, is the format is inconsistent. For example on some links pointing to the forums that go to: https://forums.wpsharks.com/c/s2member; some links are s2member.com/forums/, while others are s2member.com/r/forums/.

Should all the links now be in that format: s2member.com/r/*?

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jan 27, 2017

Yes, all external links should use redirects (s2member.com/r/[slug]). @renzms can you please provide a list of links and their locations that are not using redirects?

@renzms
Copy link
Contributor

@renzms renzms commented Jan 29, 2017

@raamdev

can you please provide a list of links and their locations that are not using redirects?

Sure thing! 👍

@renzms
Copy link
Contributor

@renzms renzms commented Jan 30, 2017

Links to external sites

s2Member header links

Dashboard → s2Member → Getting Started → Your Registration Form

Dashboard → s2Member → Getting Started → Getting Help with s2Member

Dashboard → s2Member → General Options → Localhost WAMP/MAMP

Dashboard → s2Member → General Options → Email Configuration → New User Email Configuration → Yes,... → New User Email Message (click to customize)

Dashboard → s2Member → General Options → Email Configuration → New User Email Configuration → Yes,... → Administrative: New User Notification (click to customize)

Dashboard → s2Member → General Options → Membership Levels

Dashboard → s2Member → General Options → CAPTCHA Anti Spam Security

Dashboard → s2Member → Restriction Options → Post Access Restrictions

Dashboard → s2Member → Restriction Options → Page Access Restrictions

Dashboard → s2Member → Restriction Options → Tag Access Restrictions

Dashboard → s2Member → Restriction Options → Tag Access Restrictions

Dashboard → s2Member → Restriction Options → Category Access Restrictions

Dashboard → s2Member → Restriction Options → Alternative View Protection

Dashboard → s2Member → Restriction Options → Specific Post/Page Access Restrictions

Dashboard → s2Member → Restriction Options → Brute Force IP Restrictions

Dashboard → s2Member → Restriction Options → Simultaneous Login Restrictions

Dashboard → s2Member → Download Options →Advanced Download Restrictions

Dashboard → s2Member → Download Options → Remote Auth/Broadcasting

Dashboard → s2Member → Download Options → JW Player v7 & RTMP Protocol Examples

Dashboard → s2Member → Download Options → Shortcode Attributes & API Functions (Explained) → [s2File /] & [s2Stream /] Shortcode Attributes:

Dashboard → s2Member → Download Options → Shortcode Attributes & API Functions (Explained) → Additional [s2Stream /] Shortcode Attributes:

Dashboard → s2Member → Download Options → Shortcode Attributes & API Functions (Explained) → [s2Key /] Shortcode Attributes:

Dashboard → s2Member → Pro Coupon Codes → Pro Affiliate Coupon Codes

Dashboard → s2Member → PayPal Options → PayPal Account Details

Dashboard → s2Member → PayPal Options → PayPal IPN Integration → IPN w/ Proxy Key (optional, for 3rd-party integrations)

Dashboard → s2Member → PayPal Pro Forms → Custom Return URLs Upon Success → Free Registration Forms (open/close) - %%s_response%%

Dashboard → s2Member → PayPal Pro Forms → Custom Return URLs Upon Success → Membership Sales / Signups & Modifications (open/close) - %%s_response%%

Dashboard → s2Member → PayPal Pro Forms → Custom Return URLs Upon Success → Independent Custom Capability Sales (open/close) - %%s_response%%

Dashboard → s2Member → PayPal Pro Forms → Custom Return URLs Upon Success → Specific Post/Page Transactions (open/close) - %%s_response%%

Dashboard → s2Member → PayPal Pro Forms → Custom Return URLs Upon Success → Cancellations & Billing Updates (open/close) - %%s_response%%

Dashboard → s2Member → Stripe Pro Forms → Custom Return URLs Upon Success → Free Registration Forms (open/close) - %%s_response%%

Dashboard → s2Member → Stripe Pro Forms → Custom Return URLs Upon Success → Membership Sales / Signups & Modifications (open/close) - %%s_response%%

Dashboard → s2Member → Stripe Pro Forms → Custom Return URLs Upon Success → Independent Custom Capability Sales (open/close) - %%s_response%%

Dashboard → s2Member → Stripe Pro Forms → Custom Return URLs Upon Success → Specific Post/Page Transactions (open/close) - %%s_response%%

Dashboard → s2Member → Stripe Pro Forms → Custom Return URLs Upon Success → Cancellations & Billing Updates (open/close) - %%s_response%%

Dashboard → s2Member → API / Scripting → Simple Conditionals

Dashboard → s2Member → API / Scripting → Advanced/PHP Conditionals

Dashboard → s2Member → API / Scripting → Advanced/PHP Query Conditionals

Dashboard → s2Member → API / Scripting → Custom Capabilities(Packages)

Dashboard → s2Member → API / Scripting → Custom Capability and Member Level Files

Dashboard → s2Member → API / Scripting → s2Member Content Dripping

Dashboard → s2Member → API / Scripting → s2Member PHP/API Constants

Dashboard → s2Member → API / Scripting → Pro Login Widget via PHP

Dashboard → s2Member → API / Scripting → Hooks/Filters

Dashboard → s2Member → Log Files (Debug) → Logs Viewer - Debugging Tools/Tips & Other Important Details (click here to toggle)

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jan 30, 2017

@renzms Wow! Thanks so much for gathering all that data. It looks like we have several links in there that currently lead to a 404 (another reason we should always be using redirects!), so I'm glad you caught those.

@jaswsinc Is there any problem with me replacing all of those links with proper redirects (i.e., s2member.com/r/[slug])?

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Jan 30, 2017

Nice work!! @renzms @raamdev
Nope. Not a problem at all. I'd love to see redirects for those.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jan 30, 2017

@jaswsinc Can you tell me where these should be pointing to?

Dashboard → s2Member → Pro Coupon Codes → Pro Affiliate Coupon Codes

iDevAffiliate - http://www.s2member.com/idev-affiliate - redirects to 404
iDevAffiliate - http://www.s2member.com/idev-affiliate - redirects to 404
iDevAffiliate - http://www.s2member.com/idev-affiliate - redirects to 404

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Jan 30, 2017

The ShareASale link is correct.

The iDev links you can point to:
https://s2member.com/kb-article/idevaffiliate-commission-tracking/

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Jan 30, 2017

@renzms
Copy link
Contributor

@renzms renzms commented Jan 31, 2017

@jaswsinc @raamdev

In Dashboard → s2Member → API / Scripting → Integrating iDevAffiliate,

there's a proper redirect link for iDevAffiliate, http://www.s2member.com/r/idevaffiliate/, but it redirects to: http://www.idevdirect.com/idevaffiliate.php.

Not sure if you want to change that also, so they all conform to

https://s2member.com/kb-article/idevaffiliate-commission-tracking/

Or, to: https://s2member.com/affiliate-program-integrations/

or to keep them as they are.

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Feb 1, 2017

there's a proper redirect link for iDevAffiliate, http://www.s2member.com/r/idevaffiliate/, but it redirects to: http://www.idevdirect.com/idevaffiliate.php.

Thanks. I think that one is OK like it is.

@raamdev raamdev self-assigned this Feb 1, 2017
@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 17, 2017

I've updated all of the links Renz mentioned above to use s2member/r/ redirects.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 21, 2017

s2Member v170221 has been released and includes changes from this GitHub Issue. See the v170221 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1027).

@raamdev raamdev closed this Feb 21, 2017
@wpsharks wpsharks locked and limited conversation to collaborators Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants