Authorize.Net Failed Payments Offset

[jaswrks]

A customer writes...

I set 'Max Payment Failures (for Authorize.Net Integration Only)' to 1 and expected s2Member to cancel the subscription on first failed recurring payment. It does not apparently: code snippet from authnet-notify-in.inc.php

if($GLOBALS['WS_PLUGIN__']['s2member']['o']['pro_authnet_max_payment_failures']
&& ($current_payment_failures = get_user_option('s2member_authnet_payment_failures', $user_id)) >= $GLOBALS['WS_PLUGIN__']['s2member']['o']['pro_authnet_max_payment_failures']
)

$current_payment_failures will be 0 on first failed payment - the condition above will be false and you don't issue EOT.

I would change my setting from 1 to 0, but the help text says: "If you don't want s2Member to monitor failed payments you can set this to 0".

So what to do?

[jaswrks]

Customer also writes...

Also, please confirm that the AuthNet subscription gets cancelled as well in this case. I didn't see it in this file and didn't debug more.

No, this is the not the case. Max Failed Payments being reached on the Authorize.Net side does not trigger a termination of the ARB itself; it only terminates access to the site. However, given that this is an attempt on the part of s2Member to supplement what is lacking in Authorize.Net when it comes to failed payments, I'd agree that it would be best to do so. I'm going to add that onto the issue as well.

[jaswrks]

Next Release Changelog:

• (s2Member Pro) Bug Fix: A feature that was previously introduced in v140816, which made it possible for site owners to set a failed payment threshold (in s2Member's Authorize.Net integration), was suffering from an off-by-one issue during total failed payment calculations. Fixed in this release. See also this GitHub issue if you'd like further details.
• (s2Member Pro) Feature Enhancement: Whenever a failed payment threshold is reached (in s2Member's Authorize.Net integration), not only will s2Member terminate on-site access, but now the underlying ARB (Automated Recurring Profile) is cancelled at the same exact time. This way future billing attempts on the Authorize.Net side will not be possible; i.e. it ensures that a failed payment threshold will always terminate both on-site access and the ARB itself together at the same time, as opposed to allowing the ARB termination to occur automatically via Authorize.Net, whenever. See also this GitHub issue if you'd like further details.

[jaswrks]

Work from this issue went out with the release of s2Member v150102.
http://www.s2member.com/changelog/#s2-changes-v150102