Skip to content

Automatic Plugin Updates causing problems with s2Member Pro #523

Closed
@raamdev

Description

@raamdev

Automatic Background Updates were introduced in WordPress v3.7 and while by default only WordPress Core Updates are updated automatically, it's still possible to enable automatic updates for everything, including themes and plugins. Some web hosting companies might be enabling automatic plugin updates in attempt to improve overall security.

There's also plugin called Automatic Plugin Updates that a site owner can install to enable automatic plugin updates using the build-in WordPress background update mechanism. Some site owners might be using this.

The problem with automatic plugin updates is that s2Member Pro requires manual intervention to be updated. (You must supply your username and password and then click the upgrade button after the s2Member Framework has been upgraded.) If s2Member Framework is updated automatically and s2Member Pro is not updated, then you end up with a broken s2Member installation and Pro-Forms start showing up as plain text.

WordPress allows for disabling automatic updates for specific plugins as follows (this needs to be tested, but was adopted from here):

function disable_s2member_auto_update ( $update, $item ) {
    if ( in_array( $item->slug, array('s2member') ) ) {
        return false; // Never allow automatic s2Member updates
    } else {
        return $update; // Else, use the normal API response to decide whether to update or not
    }
}
add_filter( 'auto_update_plugin', 'disable_s2member_auto_update', 10, 2 );

I propose we add something like this to s2Member Pro to remove any possibility of an automatic s2Member Framework update, which would break s2Member Pro.


Internal Support Tickets Referencing this Issue

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions