Wrong Checkout Message When Using Pro Form MODIFY Attribute

[patdumond]

Referencing internal ticket: https://websharks.zendesk.com/agent/tickets/6389

Steps to Reproduce

Confirmed on WordPress 4.2.2 (Clean Install), Twenty Fifteen 1.2, and s2Member 150311 + s2Member Pro v150311.

1. Add the following Billing Modification shortcode to a Post/Page (note that modify="1" attribute, indicating it's a modification form):

   [s2Member-Pro-PayPal-Form level="1" ccaps="" desc="$0.01 USD / One Time (for 1 month access, non-recurring, no trial)" ps="paypal" lc="" cc="USD" dg="0" ns="1" custom="example.com" ta="0" tp="0" tt="D" ra="0.01" rp="1" rt="M" rr="BN" rrt="" rra="2" accept="paypal" accept_via_paypal="paypal" coupon="" accept_coupons="0" default_country_code="" captcha="0" modify="1" /]
   

2. Login with a test user account and submit the form to upgrade the account.

Expected behavior

Since the user is already logged in, the message displayed should simply state (without any mention of needing to log back in, as the user is already logged in):

Thank you. Your account has been updated.

Observed behavior

When a customer checks out using a Pro-Form that includes the modify="1" attribute, a message is displayed that says:

Thank you. Your account has been updated. Please log back in now.

This is the wrong message for the following reason: The user is already logged in during the checkout because s2Member does force a Customer to be logged-in before they can fill out the Form when the modify="1" directive is included in the Pro-Form shortcode.

[raamdev]

Short-term Workaround

As a temporary workaround while this bug is being fixed, you could instead use the success="" attribute in your Pro-Form shortcode. This will allow you to redirect customers to a specific page that you like best; i.e., one that contains a message that you prefer to show. Please see: Dashboard → s2Member → PayPal Pro-Forms → Custom Return URLs Upon Success for further details.

[BugRat]

Thank you Raam.
Unfortunately adding the success="" attribute to the Pro-Form does not really help.
It is important that the message is displayed ONLY IF a customer made a payment.

I explained this in more detail in #568

[jaswrks]

Next Release Changelog:

• (s2Member Pro) Message After Modification: This release improves the default response that a customer who is upgrading/downgrading receives after having completed checkout using a Pro-Form. Instead of asking the customer to "log back in", s2Member simply says, "Thank you. Your account has been updated.". There is no reason for a customer to log back in; i.e., this is not necessary, and that message was leading to some confusion. Note also that with Pro-Forms you can provide a Custom Return URL on Success using the success="" shortcode attribute. Thus, this message is simply a default. We suggest that you customize in all cases. See this GitHub issue if you'd like additional details. Props to @patdumond for reporting this important issue.

[jaswrks]

The latest release of s2Member v150722+ closes this issue.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)