Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Pro Upgrader #668

Closed
jaswrks opened this issue Aug 4, 2015 · 15 comments
Closed

Revamp Pro Upgrader #668

jaswrks opened this issue Aug 4, 2015 · 15 comments

Comments

@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Aug 4, 2015

  • Bring it up-to-date with the latest API @ s2member.com
  • Bring it up-to-date with the latest WordPress integration implemented in ZenCache and Comment Mail. As a result, make it more compatible with ZenCache also. Referencing: wpsharks/comet-cache#508
  • Rewrite the pro upgrader to clean things up (OMG, what a mess it was!), but leave the existing design for now. Mostly because the pro version is still not an official WP plugin that can be updated in the same way that our others can.
  • Ask for license key instead of password.
@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 22, 2016

Referencing #746 where a current issue was discussed with regards to Pro-Forms on a live site showing up as plain-text when the Framework is inadvertantly updated without the Pro module also being updated. If we can figure out a way to solve that problem as part of this Pro Upgrader revamp, that would be great.

@jaswrks jaswrks added this to the Next Release milestone Jan 5, 2017
@jaswrks jaswrks self-assigned this Jan 5, 2017
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
…to s2member.com locations. See: wpsharks/s2member#1027 and wpsharks/s2member#668
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
jaswsinc
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
…to s2member.com locations. See: wpsharks/s2member#1027 and wpsharks/s2member#668
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
jaswsinc
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jan 5, 2017
jaswsinc
@renzms
Copy link
Contributor

@renzms renzms commented Jan 26, 2017

@jaswsinc

Tested using s2Member v170126-RC

Should it say Password, or should it only say License on the preview text in the field and instructions?
screen shot 2017-01-26 at 9 40 15 pm

When the information is saved however, it will pull up the username and correctly input the saved License number in the field.
screen shot 2017-01-26 at 9 40 50 pm

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Jan 30, 2017

Hmm. I'm not sure why, but that's not the newly updated upgrade panel that I'm seeing in your screenshot. See these lines in the dev branch that were updated recently. It should ask for a license key now, not a password.

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Jan 31, 2017

2017-01-30_16-02-45

@renzms
Copy link
Contributor

@renzms renzms commented Jan 31, 2017

That's strange. No matter what I do, in a clean installation and making sure plugin deletion safeguards isn't saving anything, it still says Password.

screen shot 2017-01-31 at 9 41 48 pm

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jan 31, 2017

Yep, I'm seeing the same thing:

2017-01-31_16-10-04

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jan 31, 2017

DOh... if we're seeing an upgrade notice, that means that an older version of the s2Member Pro module is currently installed (with a newer version of s2Member Framework, hence the upgrade message). The older s2Member Pro module will not have the newer upgrade dialog, so what we're seeing above should be expected!

The only way to test the newer upgrade dialog would be to install the s2Member Pro v170126-RC module, and then install an s2Member Framework that is newer than v170126-RC (which doesn't exist yet).

So, the best way to test this would be to temporarily generate a newer version of the s2Member Framework (e.g., v170131-RC) and then install that with the s2Member Pro v170126-RC module in wp-content/plugins/.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jan 31, 2017

@renzms here's a version of s2Member Framework that is newer than the RC that you can use to test the Pro Add-On upgrade dialog: s2member-framework-2017-01-31.zip

I confirmed the new dialog showed up as expected and confirmed that the upgrade process was still working:

2017-01-31_16-23-53

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 1, 2017

@jaswsinc I see this item on your checklist at the top still remains:

  • Bring it up-to-date with the latest WordPress integration implemented in ZenCache and Comment Mail. As a result, make it more compatible with ZenCache also. Referencing: wpsharks/comet-cache#508

I assume the intention is to push that work to a future release, correct?

@renzms
Copy link
Contributor

@renzms renzms commented Feb 2, 2017

@raamdev

Thanks! Yes that makes more sense as to why the old version was showing up.

screen shot 2017-02-02 at 12 34 28 pm

Confirmed Working!

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Feb 3, 2017

@raamdev writes...

I assume the intention is to push that work to a future release, correct?

Yes. Mostly because the pro version is still not an official WP plugin that can be updated in the same way that our others can. The remaining work here is blocked by that larger problem. So for now, I just rewrote the upgrader using the same underlying concepts that it operated on previously.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 3, 2017

@jaswsinc writes...

the pro version is still not an official WP plugin that can be updated in the same way that our others can.

Hmm, it was my understanding that the last todo item up there was about doing away with the built-in Pro updater in s2Member and integrating with the native WordPress plugin updater, the way we do now in Comet Cache Pro (which is not an "official WP plugin" either...). Am I missing something?

@jaswrks
Copy link
Contributor Author

@jaswrks jaswrks commented Feb 3, 2017

The pro add-on in s2Member is not an installable plugin. That's the difference. So it can't be treated like an installable plugin in the updater either; i.e., if we tried to do with s2Member what we have done with Comet Cache it won't work yet.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 3, 2017

The pro add-on in s2Member is not an installable plugin. That's the difference.

Ah, got it. Thank you.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 21, 2017

s2Member v170221 has been released and includes changes from this GitHub Issue. See the v170221 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#668).

@raamdev raamdev closed this Feb 21, 2017
@wpsharks wpsharks locked and limited conversation to collaborators Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.