Skip to content

s2Member Pro upgrade dialog visible to non-admins #697

Closed

Description

@raamdev

The s2Member Pro upgrader dialog is visible to non-Admins. Here I'm logged in as a Subscriber to the Dashboard and I can see the upgrade dialog:

2015-08-25_16-10-32

This dialog should only be visible to Admins.

Activity

  1. added this to the Next Release milestone on Sep 22, 2015
  2. self-assigned this
    on Sep 22, 2015
  3. jaswrks commented on Sep 22, 2015

    @jaswrks
    Contributor

    Next Actions

    • Before this line of code add the following.

      if(!current_user_can('update_plugins'))
          return ''; // Not applicable.
    • The same before this line of code, except return; instead of return '';.

    • Submit PR.

  4. added a commit that references this issue on Sep 23, 2015
    d7c2416
  5. jaswrks commented on Sep 23, 2015

    @jaswrks
    Contributor

    Next Release Changelog:

    • (s2Member Pro) Bug Fix: This release corrects a security issue related to the Pro Upgrade Wizard for s2Member Pro being displayed without checking current_user_can('update_plugins'). Resolved. Props @raamdev for identifying this and working to implement the fix. See this GitHub issue if you'd like additional details.
  6. removed their assignment
    on Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions