Stripe Bug: Hash on Coupon Apply

[jaswrks]

Overview

When applying a coupon code the Stripe Pro-Form should be submitted with the #s2p-form hash just as it does when you select a checkout option. Otherwise, if the Pro-Form is displayed further down the page, a customer might miss the coupon having been applied; i.e., they would need to scroll down to see it.

Steps to Reproduce

• Setup a Stripe Pro-Form on a page with a long block of text before it.
• Enter a coupon code and press "Apply Coupon".

Expected Behavior

That the form would be submitted and move you back to the Pro-Form, instead of to the top of the page.

Observed Behavior

The coupon is applied, but the page is reloaded and the scroll position is at the very top of the page instead of back at the Pro-Form.

[jaswrks]

Next Actions

• See this line of code

• Change it to:

  $(submissionNonceVerification).val('apply-coupon'), 
  $coForm.attr('action', $coForm.attr('action').replace(/#.*$/, '') + '#s2p-form'),
  $coForm.submit(); // Submit form with hash positioning.

• YUI compress stripe.js into stripe-min.js

• Submit PR.

[jaswrks]

YUI compress stripe.js into stripe-min.js

This is not absolutely necessary, so if it slows you way down, just submit the PR and I'll compress.

[jaswrks]

@raamdev You can take note of the $ symbol in that JavaScript you're working with. Note that $ = jQuery. Also, any variable that I write in JavaScript that starts with $ is a jQuery object instance. You can learn more about jQuery selectors here: http://api.jquery.com/jQuery/

[jaswrks]

Next Release Changelog:

• (s2Member Pro) Bug Fix: Stripe Pro-Forms presented after a long block of text on a page, were not returning to the proper hash location after a Coupon Code was applied. Fixed in this release. Props @raamdev See also: this GitHub issue if you'd like additional details.