wp-includes/load.php patch unverifiable.

[crazycoolcam]

On updating my WP to 4.4 and s2Member to the latest version, the upgrade said the network patches worked, but using the multisite page to patch the files automatically returned an "unverifiable" error to the load.php patch.

It appears as though WP has changed the details of the line in question to use a function rather than a constant. I believe the line now reads:
if ( empty( $active_plugins ) || wp_installing() )

I manually patched my file to add the preg_match info, but fixing the updater is a good idea. :)

[jaswrks]

@crazycoolcam Thanks for reporting this! I'm giving this a high priority for our next release.

[crazycoolcam]

Sounds good. :)

[jaswrks]

Next Release Changelog:

• (s2Member/s2Member Pro) WP v4.4 Compat.: This release corrects an issue that impacted sites attempting to run s2Member on a Multisite Network; i.e., it corrects a problem with the load.php patch against the latest release of WordPress. Props @crazycoolcam for reporting! See also this GitHub issue.

[jaswrks]

Work from this issue was pushed out with the release of s2Member v151218.
See: http://s2member.com/changelog/ for full details.

Future comments on this issue will now be blocked. If you have any trouble please open a new issue and report it. A big thanks to all of our great supporters. Happy Holidays :-) ❄️

[jaswrks]

Reopening this issue, as it seems we broke WordPress v4.3 compat. with this update. Working great in WP v4.4 now, but older copies of WordPress receive the wp_installing() call, which does not work on WP v4.3; i.e., that function did not exist in 4.3.

[jaswrks]

Closing this in favor of: #842 where work is underway to eliminate the need for MS patches altogether.