Password setup email still being sent when user chooses password at registration

[rossagrant]

Hey Jason and everyone!

Hope you're well. I might be mistaken, but I thought the issue with password emails still being sent - even when a user sets it at registration had been fixed here:

#732

I've just tested it on WP 4.4.2 and this unwanted behaviour still exists.

Any ideas? It means users set a password, then end up changing it 2 minutes later! Haha!

Thanks again!

[nmangold]

I am also experiencing this issue in WP 4.4.2.

[rossagrant]

Just to confirm, I still have this happening in WP 4.5 too. It seems to be confusing users a little!

[raamdev]

@rossagrant @nmangold Can you give me a list of steps to reproduce this? I just tested WP 4.5 + s2Member v160414-RC with Custom Passwords enabled (s2Member → General Options → Registration/Profile Fields & Options → Allow Custom Passwords = Yes) and a Free Registration Pro-Form.

When I created a new account using the Pro-Form and set a password as part of the registration process, I did not receive any email asking me to reset the password.

Could one of you try to reproduce this issue with v160414-RC? That will be an official release tomorrow, so if there's still an issue with the Custom Passwords it would be nice to get that fixed before tomorrow's official release.

[nmangold]

I upgraded to WP 4.5, and updated s2member to version 160303, the problem seems to be resolved for me.

[raamdev]

@nmangold Thank you for the update. I'm going to close this issue.

[rossagrant]

Hey @raamdev!

So sorry for the late reply here.

I still have this problem, even in the very latest S2 version released yesterday.

I am NOT using a pro form - I am simply allowing free registration through WP's native form.

Do I have to use a form or can I not let WP deal with free registrations?

Thanks! :)

[raamdev]

@rossagrant Thank you for that additional information.

I have confirmed this is a bug.

Steps to reproduce

1. Install s2Member Framework v160424 (also confirmed this bug with Pro Add-On installed)
2. Set s2Member → General Options → Registration/Profile Fields & Options → Allow Custom Passwords During Registration? to Yes
3. Set s2Member → General Options → Open Registration to Yes
4. Visit /wp-login.php?action=register and register an account, setting your own password during registration

Expected Behavior

Since user has created their password during registration, they should not receive any email asking them to set their password. They've already set their password, so they can just login.

Observed Behavior

User receives a Your username and password info email with a link to set their password:

---

Username: example

To set your password, visit the following address:

http://example.com/wp-login.php?action=rp&key=GerQyioL1L5P7KGzyTrh&login=example

http://example.com/wp-login.php

[rossagrant]

Hi guys! Any news on which release we may see a fix for this?

Thank you! :)

[rossagrant]

Hey Jason - no mega rush on this, I just wondered if you guys had figured out a fix for this issue yet? If there is anything I can do to help test - please don't hesitate to let me know! :)

[rossagrant]

Hey guys! Hope you're all well.

Any closer to pushing a patch out for this yet? I'm still getting members confused that they are being asked to set a password, just seconds after already doing so via registration.

Thanks :)

[jaswrks]

Next Release Changelog:

• Bug Fix: Username/password email being sent to users whenever Custom Passwords are enabled in your s2Member configuration and registration occurs via the default wp-login.php?action=register form. Fixed in this release. See also: issue #870 if you'd like additional details.

[renzms]

@jaswsinc @raamdev

Confirmed Working. 👍

No email is received when Custom Passwords are allowed.

Is the message Registration complete. Please check your email., default via WordPress? It could be confusing for users who are waiting around for an email when they can just log in right away. Maybe there should be a note to change that (a message on how a site owner can change that), or maybe an option to have that changed when enabling custom passwords.

[jaswrks]

@renzms Thank you :-)

Is the message Registration complete. Please check your email., default via WordPress?

Yes, that comes from WP core, but it should be translated by s2Member automatically whenever custom passwords are enabled. Looks like you found another bug, so thank you! I just tweaked this a bit to cover the scenario where e-mail is spelled email instead.

[rossagrant]

Absolutely superb Jason! Thanks so much for this - it's been confusing users for quite a while now. Really do appreciate you my man! :)

[raamdev]

s2Member v161129 has been released and includes changes from this GitHub Issue. See the v161129 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#870).