Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Problems in stripe-notify-in.inc.php #874

Closed
patdumond opened this issue Feb 10, 2016 · 4 comments
Closed

Possible Problems in stripe-notify-in.inc.php #874

patdumond opened this issue Feb 10, 2016 · 4 comments
Assignees

Comments

@patdumond
Copy link

@patdumond patdumond commented Feb 10, 2016

A user has reported that Refund Notifications for Stripe do not work. He tracked down 5 instances where $strip_charge should be $stripe_charge, preventing charge.refunded events from being processed at all and also preventing charge.dispute_created events from having the correct amount reported.

He also reported having to "massage" the amount refunded using c_ws_plugin__s2member_pro_stripe_utilities::cents_to_dollar_amount(). Otherwise, a $42.00 refund, for example, comes back as $4200.00.

Referencing Private Internal Ticket: https://websharks.zendesk.com/agent/tickets/11118.

@YearOfBenj
Copy link

@YearOfBenj YearOfBenj commented Feb 10, 2016

Let me know if a patch would be helpful.

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Feb 11, 2016
@jaswrks jaswrks added this to the Next Release milestone Feb 11, 2016
@jaswrks jaswrks self-assigned this Feb 11, 2016
@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Feb 11, 2016

Next Release Changelog:

  • (s2Member Pro) Stripe Bug Fix: This release corrects a bug caused by typos in the source code that were preventing refunds from being processed as expected whenever Stripe was integrated. Props @YearOfBenj for reporting this important issue. Props @patdumond for relaying vital information. See also this GitHub issue if you'd like additional details.
@jaswrks jaswrks closed this Feb 11, 2016
@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Feb 11, 2016

Fixed. Thank you! for reporting @YearOfBenj and @patdumond :-)

@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Feb 11, 2016

He also reported having to "massage" the amount refunded using c_ws_plugin__s2member_pro_stripe_utilities::cents_to_dollar_amount(). Otherwise, a $42.00 refund, for example, comes back as $4200.00.

On deck... needs testing.

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Feb 11, 2016
@jaswrks jaswrks removed the needs testing label Feb 11, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Apr 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.