Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with translate.wordpress.org #899

Closed
KTS915 opened this issue Mar 10, 2016 · 9 comments
Closed

Compatibility with translate.wordpress.org #899

KTS915 opened this issue Mar 10, 2016 · 9 comments
Assignees
Milestone

Comments

@KTS915
Copy link

@KTS915 KTS915 commented Mar 10, 2016

As you probably know, WordPress recently decided to encourage translations of themes and plugins to be done in a different way from before. One user has asked about this here: https://wordpress.org/support/topic/translation-537?replies=1

It seems that the issue is that s2Member needs to follow the instructions here: https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/

You can measure progress here: https://translate.wordpress.org/projects/wp-plugins/s2member

@Li-An
Copy link

@Li-An Li-An commented Mar 10, 2016

Well, it seems that S2Member is internationalized BUT... if I managed to create french mo and po working in S2Member Pro, nobody managed to make it work for the free S2Member at the time I made the translation. My translation file are here: http://www.echodesplugins.li-an.fr/mes-traductions-wp/#s2member

Reading WP instructions, the po and mo files should have been automatically detected. And it seems it's not.

@raamdev
Copy link
Contributor

@raamdev raamdev commented Mar 10, 2016

Hmm, the translate.wordpress.org site says the plugin is "not properly prepared for localization", but gives no indication of what the problem is:

2016-03-10_12-37-36

The link in that message just describes how to internationalize a plugin. As far as I'm aware, s2Member already follows everything listed there.

I wonder if there are any online tools that allow you scan the plugin and list specific issues preventing it from being "properly prepared for localization".

@raamdev raamdev changed the title Make s2Member Translatable Compatibility with translate.wordpress.org Mar 10, 2016
@Li-An
Copy link

@Li-An Li-An commented Mar 10, 2016

As I said, there was already a problem with S2Member Free version - french mo files were not detected.

@KTS915
Copy link
Author

@KTS915 KTS915 commented Mar 10, 2016

WP says it's using GlotPress, so perhaps you could use the GlotPress plugin to help you. I just took a look myself, and it's all Greek to me, but perhaps it will make sense to you, @raamdev!

Here it is: https://wordpress.org/plugins/glotpress/

@KTS915
Copy link
Author

@KTS915 KTS915 commented Mar 11, 2016

Just realized I opened Issue #864 about this, so am now closing that one in favor of this.

@Li-An
Copy link

@Li-An Li-An commented Mar 11, 2016

Glotpress is only an interface to translate - the interface used on WP site. So it won't help about S2member problem :-)

@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Mar 23, 2016

Thanks for the heads up. It looks like s2Member might need to move the load_plugin_textdomain() call that it has to the plugins_loaded hook. That's a best guess at why their system is saying it is not ready. Currently, we load the text domain on init and it is suggested that we use plugins_loaded.

https://github.com/websharks/s2member/blob/000000-dev/s2member/includes/hooks.inc.php#L24

@jaswrks jaswrks added the bug label Mar 23, 2016
@jaswrks jaswrks self-assigned this Apr 15, 2016
@jaswrks jaswrks added this to the Next Release milestone Apr 15, 2016
jaswrks pushed a commit that referenced this issue Apr 15, 2016
@jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Apr 15, 2016

Next Release Changelog:

  • (s2Member/s2Member Pro) i18n Compatibility: This release of s2Member moves the load_plugin_textdomain() call into the plugins_loaded hook instead of it being run on init. Props @KTS915 for reporting. See also: this GitHub issue for details.
@jaswrks jaswrks closed this Apr 15, 2016
@jaswrks jaswrks modified the milestones: Future Release, Next Release Apr 23, 2016
@raamdev raamdev reopened this Nov 15, 2016
@raamdev
Copy link
Contributor

@raamdev raamdev commented Nov 29, 2016

s2Member v161129 has been released and includes changes from this GitHub Issue. See the v161129 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#899).

@raamdev raamdev closed this Nov 29, 2016
@wpsharks wpsharks locked and limited conversation to collaborators Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.