Email Field on Registration page not shown as Compulsory

[spottydog63]

Looking at the default Registration Fields, the Username, First Name, and Last Name are all compulsory as indicated with the *Asterix next to the Labels.
However, the Email Field does not have an *Asterix.
It is my understanding that it is a Required Field, yet it doesn't appear that way.

[raamdev]

@spottydog63 Thank you for the bug report.

I have confirmed that this appears to be a bug (tested s2Member v160303):

It's worth noting also that the default WordPress registration page (with s2Member disabled) does not have any required field indicators:

[spottydog63]

Hi.
Is there any further info on this?
Regards
Iain

[jaswrks]

Referencing this line in the s2Member codebase that expects the original string to be E-mail (with a dash). However, it now looks like this has changed in a recent version of WordPress, so we should remove the dash to restore the intended translation there in the s2Member source code.

@renzms Is this something you could help with?

[renzms]

@jaswsinc

PR Submitted, ready for review, thanks!

[jaswrks]

Next Release Changelog:

• (s2Member/s2Member Pro) Bug Fix: Email field on Registration page not shown as required via * symbol like other fields in this form. Caused by a change in WordPress core. Fixed in this release. Props @spottydog63 @renzms. See also: this GitHub issue for details.

[jaswrks]

s2Member & s2Member Pro v160423 have been released and they include changes from this GitHub Issue. See the v160423 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)