PHP Notices on PHP7

[KTS915]

When on the admin pages of some other plugins on my localhost site running PHP7, Query Monitor reports the following PHP Notices:

Undefined index: login_welcome_page 
wp-content/plugins/s2member/includes/classes/cache.inc.php:51

Undefined index: membership_options_page
wp-content/plugins/s2member/includes/classes/cache.inc.php:52   

Undefined index: file_download_limit_exceeded_page  
wp-content/plugins/s2member/includes/classes/cache.inc.php:53

[KTS915]

Found another one when on the s2Member -> Import/Exports admin page. This says:

Undefined index: ws_plugin__s2member_pro_import_users_direct_input
wp-content/plugins/s2member-pro/includes/menu-pages/import-export.inc.php:190

[KTS915]

Changing lines 51, 52, and 53 of s2member/includes/classes/cache.inc.php to the following seems to fix the first set of issues:

                        $lwp_cache = isset($GLOBALS["WS_PLUGIN__"]["s2member"]["c"]["cache"]["login_welcome_page"]);
                        $mop_cache = isset($GLOBALS["WS_PLUGIN__"]["s2member"]["c"]["cache"]["membership_options_page"]);
                        $fdlep_cache = isset($GLOBALS["WS_PLUGIN__"]["s2member"]["c"]["cache"]["file_download_limit_exceeded_page"]);

[KTS915]

Changing line 190 of s2member-pro/includes/menu-pages/import-export.inc.php to the following seems to fix the other issue:

echo '<textarea name="ws_plugin__s2member_pro_import_users_direct_input" id="ws-plugin--s2member-pro-import-users-direct-input" rows="10" wrap="off" spellcheck="false" style="width:99%;">'.format_to_edit(trim(stripslashes(isset($_POST["ws_plugin__s2member_pro_import_users_direct_input"])))).'</textarea><br />'."\n";

[jaswrks]

@KTS915 Thanks for the follow-ups here :-)

Those isset() calls as you have them now should eliminate the notices whenever WordPress is running in WP_DEBUG mode, but you might want to consider that it's converting what would ordinarily be a string value that is being read, into nothing more than a boolean test case; i.e., isset() returns either a true or false value now. To get rid of those notices and preserve the intended functionality, you'd want something like.

$fdlep_cache = isset($GLOBALS["WS_PLUGIN__"]["s2member"]["c"]["cache"]["file_download_limit_exceeded_page"]) ? $GLOBALS["WS_PLUGIN__"]["s2member"]["c"]["cache"]["file_download_limit_exceeded_page"] : '';

[KTS915]

@jaswsinc,

Thanks for the explanation!

[jaswrks]

Next Release Changelog:

• (s2Member/s2Member Pro) Bug Fix: E_NOTICE level errors in cache handler when running in WP_DEBUG mode. Props at @KTS915 for reporting. Fixed in this release. See also: this GitHub issue.

[jaswrks]

s2Member & s2Member Pro v160423 have been released and they include changes from this GitHub Issue. See the v160423 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)